Skip to content

[WIP] KVM: Support multi vlan trunk NICs - #14166

Draft
Pearl1594 wants to merge 4 commits into
mainfrom
support-multi-vlan-guestnet
Draft

[WIP] KVM: Support multi vlan trunk NICs#14166
Pearl1594 wants to merge 4 commits into
mainfrom
support-multi-vlan-guestnet

deliver multi-VLAN trunk nics via libvirt vlan XML and bridge fallback

eb97acf
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Sep 16, 2026 in 4m 24s

Quality Gate failed

Failed conditions
37.8% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 1618 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_vlanTrunkTags" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCq828-t_SkqufYqmdL&open=AaCq828-t_SkqufYqmdL&pullRequest=14166

Check failure on line 39 in engine/schema/src/main/java/com/cloud/vm/dao/NicNetworkMapDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "nicId" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHQjdBIFDwPvW32k&open=AaChtHQjdBIFDwPvW32k&pullRequest=14166

Check warning on line 226 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCq822Lt_SkqufYqmdH&open=AaCq822Lt_SkqufYqmdH&pullRequest=14166

Check warning on line 226 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCq822Lt_SkqufYqmdJ&open=AaCq822Lt_SkqufYqmdJ&pullRequest=14166

Check warning on line 33 in engine/schema/src/main/java/com/cloud/vm/dao/NicNetworkMapDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "AllFieldsSearch" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHQjdBIFDwPvW32l&open=AaChtHQjdBIFDwPvW32l&pullRequest=14166

Check warning on line 286 in server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "String". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHbKdBIFDwPvW32r&open=AaChtHbKdBIFDwPvW32r&pullRequest=14166

Check failure on line 520 in engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the enclosing method "static" or remove this set. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHPMdBIFDwPvW32g&open=AaChtHPMdBIFDwPvW32g&pullRequest=14166

Check failure on line 519 in engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the enclosing method "static" or remove this set. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHPMdBIFDwPvW32f&open=AaChtHPMdBIFDwPvW32f&pullRequest=14166

Check failure on line 40 in engine/schema/src/main/java/com/cloud/vm/dao/NicNetworkMapDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "networkId" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHQjdBIFDwPvW32j&open=AaChtHQjdBIFDwPvW32j&pullRequest=14166

Check warning on line 308 in utils/src/main/java/org/apache/cloudstack/utils/CloudStackVersion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "java.util.List.of()" instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHaMdBIFDwPvW32q&open=AaChtHaMdBIFDwPvW32q&pullRequest=14166

Check warning on line 149 in server/src/main/java/com/cloud/hypervisor/HypervisorGuruBase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCq83Aat_SkqufYqmdN&open=AaCq83Aat_SkqufYqmdN&pullRequest=14166

Check warning on line 252 in engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using this hardcoded IP address is safe here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHPMdBIFDwPvW32e&open=AaChtHPMdBIFDwPvW32e&pullRequest=14166

Check failure on line 220 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "guest" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCq822Lt_SkqufYqmdI&open=AaCq822Lt_SkqufYqmdI&pullRequest=14166

Check warning on line 106 in utils/src/main/java/org/apache/cloudstack/utils/CloudStackVersion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "Integer.parseInt" for this string-to-int conversion. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHaMdBIFDwPvW32p&open=AaChtHaMdBIFDwPvW32p&pullRequest=14166

Check warning on line 23 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42300to2400.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make sure using this hardcoded IP address is safe here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHJVdBIFDwPvW32d&open=AaChtHJVdBIFDwPvW32d&pullRequest=14166

Check warning on line 287 in server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "String". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHbKdBIFDwPvW32s&open=AaChtHbKdBIFDwPvW32s&pullRequest=14166

Check failure on line 522 in engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the enclosing method "static" or remove this set. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHPMdBIFDwPvW32h&open=AaChtHPMdBIFDwPvW32h&pullRequest=14166

Check warning on line 0 in engine/schema/src/main/java/com/cloud/vm/dao/NicNetworkMapVO.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "java.time" API for date and time. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHPZdBIFDwPvW32i&open=AaChtHPZdBIFDwPvW32i&pullRequest=14166

Check warning on line 1617 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_vlanTrunk" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCq828-t_SkqufYqmdK&open=AaCq828-t_SkqufYqmdK&pullRequest=14166

Check warning on line 44 in utils/src/main/java/org/apache/cloudstack/utils/CloudStackVersion.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reorder the modifiers to comply with the Java Language Specification. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHaMdBIFDwPvW32o&open=AaChtHaMdBIFDwPvW32o&pullRequest=14166

Check warning on line 72 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPlugNicCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCq82u1t_SkqufYqmdG&open=AaCq82u1t_SkqufYqmdG&pullRequest=14166

Check warning on line 34 in engine/schema/src/main/java/com/cloud/vm/dao/NicNetworkMapDaoImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "NicIdsByNetworkSearch" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHQjdBIFDwPvW32m&open=AaChtHQjdBIFDwPvW32m&pullRequest=14166

Check warning on line 1898 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use multiple calls to "append" instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaCq828-t_SkqufYqmdM&open=AaCq828-t_SkqufYqmdM&pullRequest=14166

Check warning on line 6307 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Format specifiers should be used instead of string concatenation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaChtHZVdBIFDwPvW32n&open=AaChtHZVdBIFDwPvW32n&pullRequest=14166
View more details on SonarQubeCloud