Skip to content

fix(ui): validate OOBM is enabled before allowing HA on KVM hosts (#13605)#13647

Open
Chinmay048 wants to merge 4 commits into
apache:mainfrom
Chinmay048:fix-13605-kvm-ha-oobm
Open

fix(ui): validate OOBM is enabled before allowing HA on KVM hosts (#13605)#13647
Chinmay048 wants to merge 4 commits into
apache:mainfrom
Chinmay048:fix-13605-kvm-ha-oobm

Conversation

@Chinmay048

Copy link
Copy Markdown
Contributor

Description

Closes #13605

This PR updates the Vue UI infrastructure configuration (hosts.js) to validate that Out-of-Band Management (OOBM) is active and enabled before allowing administrators to configure or enable High Availability (HA) on KVM hosts. If OOBM is not enabled on a KVM host, the HA action buttons are cleanly hidden to prevent invalid configurations.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • Blocker
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

  • Verified in the Vue UI that for KVM hosts where record.outofbandmanagement.enabled is false or undefined, the "Configure HA" and "Enable HA" action buttons are properly hidden.
  • Verified that KVM hosts with active OOBM configurations (and Simulator hosts) continue to display the HA action buttons normally.

Copilot AI review requested due to automatic review settings July 19, 2026 18:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (75748a5) to head (ba1f5a5).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13647      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
+ Complexity    19792    19789       -3     
============================================
  Files          6368     6368              
  Lines        575107   575113       +6     
  Branches      70370    70370              
============================================
- Hits         113016   112996      -20     
- Misses       449808   449832      +24     
- Partials      12283    12285       +2     
Flag Coverage Δ
uitests 3.41% <ø> (-0.01%) ⬇️
unittests 20.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13647 (QA-JID-964)

@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement/UI : Cloudstack Should validate if OOBM is enabled before enabling HA on the KVM host

4 participants