Disabled Create and Add Volume button for VMs in Error state

[erikbocks]

Description

When a VM fails to deploy, it remains in Error state. Currently, there is no functionality to recover a VM in Error state, therefore, the only option is to create a new VM. However, the option Create and Add Volume is still presented. This PR disables the Create and Add Volume button for VMs in Error state

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

How Has This Been Tested?

I made the following tests, in my local lab:

1. Disabled all the hosts in my environment.
2. Tried to deploy a new VM. As expected, the deploy failed and it was set to Error state.
3. Validated that when the Volumes section was accessed, the Create and Add Volume button was still enabled.
4. Built and installed CloudStack's packages with my fix.
5. Validated that when the Volumes section was accessed again, the button was successfully disabled.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions.
  Apache CloudStack is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
  Slack: https://apachecloudstack.slack.com/

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.99%. Comparing base (39c5641) to head (75675ae).
Report is 33 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (39c5641) and HEAD (75675ae). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (39c5641)	HEAD (75675ae)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #10859       +/-   ##
=============================================
- Coverage     16.40%    3.99%   -12.41%     
=============================================
  Files          5692      401     -5291     
  Lines        501976    32654   -469322     
  Branches      60795     5791    -55004     
=============================================
- Hits          82369     1306    -81063     
+ Misses       410449    31198   -379251     
+ Partials       9158      150     -9008     

Flag	Coverage Δ
uitests	3.99% <ø> (-0.01%)	⬇️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10859 (QA-JID-620)

[bernardodemarco]

lgtm, tested in a local env

• Verified that the Create and Add Volume button was enabled for Running VMs:
  
• Verified that the Create and Add Volume button was enabled for Stopped VMs:
  
• Verified that the Create and Add Volume button was disabled for VMs in the Error state:
  

[boring-cyborg]

Awesome work, congrats on your first merged pull request!