Fix gpactivatestandby after clean shutdown. - #1889
Open
woblerr wants to merge 2 commits into
Open
Conversation
A forced activation previously relied on promote_trigger_file before starting the stopped standby, allowing startup to reach catalog access while recovery was still completing. Start the standby with GpStandbyStart and perform the normal pg_ctl promotion before reading the catalog. Share one 600-second monotonic deadline across startup, promotion, and the utility CHECKPOINT retry. Keep activation-specific handling out of gpstart and leave its CLI unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1717.
For forced activation of a stopped standby, start the postmaster directly with
GpStandbyStartinstead of usingpromote_trigger_fileandgpstart. Then promote it withpg_ctl promote, wait for a successful utilityCHECKPOINT, read the catalog, and restart the segments.The existing 600-second
pg_ctl promotetimeout is preserved. A single monotonic deadline covers standby startup, promotion, and the utilityCHECKPOINT, preventing these waits from accumulating while leaving segment restart to its existing timeout handling.