[CELEBORN-2423] Fix rack-aware replica storage selection - #3803
Open
Kalvin2077 wants to merge 1 commit into
Open
[CELEBORN-2423] Fix rack-aware replica storage selection#3803Kalvin2077 wants to merge 1 commit into
Kalvin2077 wants to merge 1 commit into
Conversation
Kalvin2077
force-pushed
the
fix/CELEBORN-2423
branch
from
August 21, 2026 08:08
8b66c7c to
109235c
Compare
Kalvin2077
marked this pull request as ready for review
August 21, 2026 08:10
Contributor
Author
|
@zaynt4606 @SteNicholas |
Contributor
|
@Kalvin2077 LGTM overall. One nit on test coverage: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This follow-up to PR #3781:
StorageInfofrom the selected replica worker.Why are the changes needed?
During best-effort fallback, the allocator could select a diskless worker for a local-disk replica or incorrectly reuse the primary worker's mount point.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
build/mvn -pl master -am -Dtest=SlotsAllocatorRackAwareSuiteJ test