Skip to content

chore: fix absolute links to camel.apache.org/security in MCP docs#24659

Merged
davsclaus merged 1 commit into
apache:mainfrom
JiriOndrusek:quick-fix/camel-jbang-mcp-relative-links
Jul 13, 2026
Merged

chore: fix absolute links to camel.apache.org/security in MCP docs#24659
davsclaus merged 1 commit into
apache:mainfrom
JiriOndrusek:quick-fix/camel-jbang-mcp-relative-links

Conversation

@JiriOndrusek

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Verify camel-website CI passes after this change is picked up by the Antora build

🤖 Generated with Claude Code

Use relative links to avoid camel-website HTML validation failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code review on behalf of @gnodet

LGTM — This is a clean documentation fix.

The change replaces two absolute https://camel.apache.org/security/ URLs with site-relative link:/security/ references in camel-jbang-mcp.adoc. This is the correct approach because:

  1. Consistent with existing code: security-model.adoc already uses link:/security/[] in 5 places for the same target page. This PR brings the MCP doc in line with that established pattern.

  2. Correct link type: The /security/ page lives on the camel.apache.org website outside the Antora module tree, so xref: cannot be used (it only works for pages within Antora modules). The link: macro with a site-relative path is the right choice.

  3. Unblocks camel-website CI: The PR description explains this fixes the camel/relative-links HTML validation rule that is blocking apache/camel-website#1693.

  4. Correct scope: Only the two absolute links in this file are changed; no other modifications.

Git history check: The affected lines were introduced in commit 1d9d6dceda3 and later in f94c4f322df (CAMEL-23852). No prior design decisions are being reverted.

Scanner coverage: No static analysis applicable (documentation-only change, no Java files modified).

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

@davsclaus davsclaus merged commit e014db9 into apache:main Jul 13, 2026
6 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • docs

🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 0 all tested

Maveniverse Scalpel detected 1 affected modules (current approach: 0).

⚠️ Modules only in Scalpel (1)
  • docs

Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules)

Modules Scalpel would test (1)
  • docs

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more


⚙️ View full build and test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants