Repository navigation
chore: fail the build when a Kamelet is not in canonical YAML DSL - #3090
Merged
Merged
Conversation
The templates of 187 of the 262 Kamelets used the compact notation, so Camel logged "YAML DSL compact notation detected" for every one of them on each load and reload: a warning a user cannot act on, about a file inside a jar. Generated with camel validate normalize (apache/camel#27449, CAMEL-25381), which rewrites only spec.template and keeps the rest of each file as written. The Kamelet validator now checks the parameters of from: against the component of its uri (not the first dependency) and accepts prefixed options such as mail.imaps.auth.mechanisms, which the canonical form makes visible to it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m
… as Camel builds the uris Review: the comments inside spec.template were dropped (82 lines in 16 Kamelets). Regenerated with camel validate normalize from apache/camel#27449 as it is now: the comments are back where they were, normalizing a normalized Kamelet changes nothing, azure-storage-files-source is kept as written (an option given two path parts was broken by the uri Camel builds), and the options are in the order Camel builds them with secret options in RAW(), as the YAML DSL wraps them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m
KameletsCanonicalTest loads every file of kamelets/ with the YAML DSL and fails when Camel logs "YAML DSL compact notation detected" for one, naming them and how to normalize them. On main before the canonical Kamelets it reports the 187 compact ones. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m
davsclaus
force-pushed
the
quick-fix/canonical-yaml-check
branch
from
October 6, 2026 16:38
d10ee92 to
bbcbecb
Compare
This was referenced Oct 6, 2026
oscerd
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code on behalf of Claus Ibsen.
Stacked on #3089, which writes the Kamelets in canonical YAML DSL. Until that one merges, this PR also shows its commit; only the last commit is new here.
This keeps the catalog canonical.
KameletsCanonicalTest(camel-kamelets-catalog) loads every file ofkamelets/with the YAML DSL and fails when Camel logsYAML DSL compact notation detectedfor one. The failure names the Kamelets and says how to fix them:It runs in the CI build,
./mvnw clean installwith tests.camel-core-engineandcamel-yaml-dsl, at${camel.version}, to load the Kamelets the way Camel does../mvnw verifypasses.