[CALCITE-7451] REINTERPRET should not be used in logical plans - #5156
Open
mihaibudiu wants to merge 1 commit into
Open
[CALCITE-7451] REINTERPRET should not be used in logical plans#5156mihaibudiu wants to merge 1 commit into
REINTERPRET should not be used in logical plans#5156mihaibudiu wants to merge 1 commit into
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7451
Changes Proposed
The semantics of REINTERPRET CAST was never specified. Moreover, the cast was inserted very early by various conversions and optimizations; at best this is supposed to be a physical operator.
This PR deprecates entirely the REINTERPRET operator and replaces all uses of it with either normal casts or expressions that produce the correct result. One prominent place where it was used was the arithmetic of interval expressions.