[CALCITE-7670] Uncollect should support LEFT JOIN UNNEST - #5149
Open
mihaibudiu wants to merge 1 commit into
Open
[CALCITE-7670] Uncollect should support LEFT JOIN UNNEST#5149mihaibudiu wants to merge 1 commit into
mihaibudiu wants to merge 1 commit into
Conversation
Contributor
Author
|
This looks like a big PR, but more than half of it is just tests. |
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
snuyanzin
reviewed
Aug 8, 2026
| * LogicalProject | ||
| * LeftSubquery | ||
| * | ||
| * <p>@see CorrelateUncollectOuterRule |
Contributor
There was a problem hiding this comment.
if <p> and @see are on the same line then it will nor render as See also
not sure if it is intended behavior here
Contributor
Author
There was a problem hiding this comment.
This should be fixable
snuyanzin
approved these changes
Aug 8, 2026
snuyanzin
left a comment
snuyanzin
left a comment
Contributor
There was a problem hiding this comment.
I have one minor comment
mihaibudiu
added
the
LGTM-will-merge-soon
Contributor
Author
|
I plan to merge this, so if you anyone has objections, now is the time to raise them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7670
Changes Proposed
The Unnest operator gains a new flag "isOuter" which indicates that it is used on the RHS of a LEFT JOIN.
This enables plans which used Correlate(left=true) + Unnest to be rewritten as Correlate(left=false) + Unnest(left=true).
Some of these plans can then be completely decorrelated, which wasn't possible previously.