Skip to content

fix: save Postgres state for apps without a partition key #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sangkyoonnam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: save Postgres state for apps without a partition key #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion burr/integrations/persisters/b_asyncpg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ async def load(

async def save(
self,
partition_key: str,
partition_key: Optional[str],
app_id: str,
sequence_id: int,
position: str,
Expand All @@ -395,6 +395,8 @@ async def save(
before the action was applied.
:return: None
"""
if partition_key is None:
partition_key = self.PARTITION_KEY_DEFAULT
logger.debug(
"saving %s, %s, %s, %s, %s, %s",
partition_key,
Expand Down
4 changes: 3 additions & 1 deletion burr/integrations/persisters/b_psycopg2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def load(

def save(
self,
partition_key: str,
partition_key: Optional[str],
app_id: str,
sequence_id: int,
position: str,
Expand All @@ -241,6 +241,8 @@ def save(
before the action was applied.
:return: None
"""
if partition_key is None:
partition_key = self.PARTITION_KEY_DEFAULT
logger.debug(
"saving %s, %s, %s, %s, %s, %s",
partition_key,
Expand Down
16 changes: 16 additions & 0 deletions tests/integrations/persisters/test_postgresql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@ def test_save_and_load_state(postgresql_persister):
assert data["state"].get_all() == {"a": 1, "b": 2}


def test_save_and_load_with_default_partition_key(postgresql_persister):
"""An application without a partition key saves and loads with partition_key=None."""
postgresql_persister.save(None, "no_pk_app", 1, "pos", state.State({"a": 1}), "completed")
data = postgresql_persister.load(None, "no_pk_app")
assert data["state"].get_all() == {"a": 1}


def test_list_app_ids(postgresql_persister):
postgresql_persister.save("pk", "app_id1", 1, "pos1", state.State({"a": 1}), "completed")
postgresql_persister.save("pk", "app_id2", 2, "pos2", state.State({"b": 2}), "completed")
Expand Down Expand Up @@ -146,6 +153,15 @@ async def test_async_save_and_load_state(asyncpostgresql_persister):
assert data["state"].get_all() == {"a": 1, "b": 2}


async def test_async_save_and_load_with_default_partition_key(asyncpostgresql_persister):
"""An application without a partition key saves and loads with partition_key=None."""
await asyncpostgresql_persister.save(
None, "no_pk_app", 1, "pos", state.State({"a": 1}), "completed"
)
data = await asyncpostgresql_persister.load(None, "no_pk_app")
assert data["state"].get_all() == {"a": 1}


async def test_async_list_app_ids(asyncpostgresql_persister):
await asyncpostgresql_persister.save(
"pk", "app_id1", 1, "pos1", state.State({"a": 1}), "completed"
Expand Down
Loading