fix(tracking): validate identifiers and keep server paths inside the storage directory - #948
Open
elijahbenizzy wants to merge 2 commits into
Open
elijahbenizzy wants to merge 2 commits into
elijahbenizzy wants to merge 2 commits into
Conversation
…storage directory Add an allowlist check for project and app identifiers in LocalBackend and a join helper that resolves paths and verifies they stay inside the configured storage directory. Bind the standalone server to 127.0.0.1 by default.
…e server endpoints Move the project/app identifier rule and the path join helper into burr.tracking.common.identifiers (shared with LocalTrackingClient), keep the LocalBackend wrappers that report failures as HTTP 400, honour BURR_SERVER_HOST for the standalone server, and extend the tests to the FastAPI endpoints, symlinked directories and client-style identifiers.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries forward #795 by @andreahlert with his commit intact, and shares the identifier rule with the tracking client (#946).
python -m burr.tracking.server.runbinds to127.0.0.1by default, overridable withBURR_SERVER_HOST, matching what theburrCLI already does. The CLI help and module docstring note that the server has no built-in authentication.23 tests added. Merge before #944, which documents this behavior.