Skip to content

show bundle info and message when doing catalog add#53

Merged
asfgit merged 1 commit into
apache:masterfrom
ahgittin:catalog-bundle-info
Jun 6, 2017
Merged

show bundle info and message when doing catalog add#53
asfgit merged 1 commit into
apache:masterfrom
ahgittin:catalog-bundle-info

Conversation

@ahgittin

@ahgittin ahgittin commented Jun 5, 2017

Copy link
Copy Markdown
Contributor

also supports backwards compatibility as only some API methods support the detail

also supports backwards compatibility as only some API methods support the detail
@asfgit

asfgit commented Jun 5, 2017

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/brooklyn-client-pull-requests/132/

@ahgittin

ahgittin commented Jun 5, 2017

Copy link
Copy Markdown
Contributor Author

@geomacy as discussed at apache/brooklyn-server#672 (comment) (and this PR only does anything with that merged, else it is safe but no-op) this supports displaying the additional message eg

% target/br catalog add file:///tmp/test672a.zip
Updated io.cloudsoft.cli44:0.12.0.SNAPSHOT as existing ID kbhxoi0ln4
* myTestEnt:0.12.0.SNAPSHOT
* myOtherTest:0.12.0.SNAPSHOT
* testent1:0.12.0.SNAPSHOT

instead of

% target/br catalog add file:///tmp/test672a.zip
myTestEnt:0.12.0.SNAPSHOT
myOtherTest:0.12.0.SNAPSHOT
testent1:0.12.0.SNAPSHOT

but falling back to that latter output if detail isn't available (old server version, or not uploading a bundle/directory)

@Graeme-Miller Graeme-Miller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asfgit asfgit merged commit a245052 into apache:master Jun 6, 2017
asfgit pushed a commit that referenced this pull request Jun 6, 2017
@geomacy

geomacy commented Jun 6, 2017

Copy link
Copy Markdown
Contributor

Looks good to me too! Sorry about late review but wouldn't have had any comments anyway :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants