Add cargo-zigbuild for release dockerfile#4805
Merged
hangc0276 merged 2 commits intoJun 1, 2026
Merged
Conversation
zymap
approved these changes
May 29, 2026
Contributor
|
Thanks for working on this! I tested this locally with Colima. The overall approach works, but the Docker image build currently misses one dependency: Zig is downloaded as a Adding |
void-ptr974
reviewed
May 31, 2026
| @@ -23,3 +23,22 @@ RUN apt-get update && \ | |||
| apt-get dist-upgrade -y && \ | |||
| apt-get install -y g++ cmake gnupg2 vim subversion less zip unzip | |||
Contributor
There was a problem hiding this comment.
apt-get install -y g++ cmake gnupg2 vim subversion less zip unzip xz-utils
hangc0276
added a commit
that referenced
this pull request
Jun 1, 2026
* Add cargo-zigbuild for release dockerfile * address comments (cherry picked from commit 0af6e60)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Fix #xyz
Main Issue: #xyz
BP: #xyz
Motivation
When releasing BookKeeper with command
./dev/release/002-release-prepare.sh, it build failed with following exceptionChanges
(Describe: what changes you have made)