Repository navigation
Conversation
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR updates the JUnit @Rule Timeout in DeltaLakeToIcebergCdcIT from a fixed 10 minutes to 5 minutes on DirectRunner and 20 minutes on other runners (such as DataflowRunner). The change is clean, well-justified, and aligns DeltaLakeToIcebergCdcIT with the existing timeout conventions in IcebergCatalogBaseIT and IcebergCdcWriteBaseIT.
🔍 General Feedback
- The runner-dependent timeout (
300seconds forDirectRunner,20 * 60seconds otherwise) provides adequate headroom for Dataflow Runner v2 worker startup and teardown while tightening timeouts for local/DirectRunner execution. - No issues found; the change is ready to merge.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41280 +/- ##
=============================================
+ Coverage 36.06% 57.74% +21.68%
Complexity 2633 2633
=============================================
Files 716 1203 +487
Lines 88226 171888 +83662
Branches 2182 2182
=============================================
+ Hits 31815 99257 +67442
- Misses 53746 69966 +16220
Partials 2665 2665 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR was auto-generated by tooling. Before moving it out of draft, the author has done a full review of the PR, specifically evaluating it on the following criteria:
Full details of the methodology of generation and review can be found here - https://docs.google.com/document/d/14lj7ECVov4T4EdwmIzNlWrRGE3lLDMOwX5xUMGzaLoc/edit?usp=sharing
If you have concerns with the PR or with the underlying methodology used to generate this, please comment below - they will be addressed by the author not the tooling :)
Summary
@Rule TimeoutinDeltaLakeToIcebergCdcITfrom a hardcoded 10 minutes (10 * 60) toTimeout.seconds(OPTIONS.getRunner().equals(DirectRunner.class) ? 300 : 20 * 60), matching the runner-dependent timeout used inIcebergCatalogBaseITandIcebergCdcWriteBaseIT.Root Cause
In the
IcebergIO Integration Tests on Dataflowworkflow (run 43366381845),DeltaLakeToIcebergCdcIT > changeFeedAppliesToIcebergTableWithChangeTypeColumnfailed withorg.junit.runners.model.TestTimedOutException: test timed out after 600 secondsatDeltaLakeToIcebergCdcIT.applyChangeFeed(DeltaLakeToIcebergCdcIT.java:340)after the Dataflow Runner v2 job had already completed all operations (Finished operation ... at 05:45:51.531Z) and was inCleaning up. Stopping worker pool...at 9m51s.Commit
ea3c5dfb210(#40230) added bothIcebergCdcWriteBaseIT(configured withTimeout.seconds(OPTIONS.getRunner().equals(DirectRunner.class) ? 300 : 20 * 60), matchingIcebergCatalogBaseIT) andDeltaLakeToIcebergCdcIT(configured with a fixed 10-minute timeout), which leaves insufficient headroom for Dataflow Runner v2 worker startup and job teardown in:sdks:java:io:iceberg:dataflowIntegrationTest.Verification
./gradlew :sdks:java:io:iceberg:spotlessCheck :sdks:java:io:iceberg:compileTestJava :sdks:java:io:iceberg:checkstyleTest.Verification
IO_Iceberg_Integration_Tests_Dataflow.ymlworkflow run on branch:43379167610