Skip to content

Apply Spotless formatting to BeamSqlLine.java - #41261

Merged
damccorm merged 1 commit into
masterfrom
fix/beam-sql-line-spotless
Nov 13, 2026
Merged

damccorm merged 1 commit into
masterfrom
fix/beam-sql-line-spotless

Conversation

@damccorm

@damccorm damccorm commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Note: this PR was auto-generated by tooling. Before moving it out of draft, the author has done a full review of the PR, specifically evaluating it on the following criteria:

  • The PR is an appropriate fix for the issue (e.g. we're not changing a test to avoid a bug)
  • The PR is a simple fix to the issue (e.g. we're not adding infra when we could just modify a test)
  • The PR is not covering for other problems (e.g. if we're bumping timeouts, it is not because we're covering for a performance problem)

Full details of the methodology of generation and review can be found here - https://docs.google.com/document/d/14lj7ECVov4T4EdwmIzNlWrRGE3lLDMOwX5xUMGzaLoc/edit?usp=sharing

If you have concerns with the PR or with the underlying methodology used to generate this, please comment below - they will be addressed by the author not the tooling :)

Summary

Applies :sdks:java:extensions:sql:jdbc:spotlessApply to BeamSqlLine.java to fix the PreCommit Spotless failure on master introduced by #41257 (8b799101a8e).

@damccorm

Copy link
Copy Markdown
Contributor Author

/gemini review

@github-actions github-actions Bot added the size/xs XS: <10 lines changed label Nov 13, 2026
@damccorm damccorm added the test-failure-cleanup Automated test health and flake cleanup PRs label Nov 13, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This pull request applies Spotless code formatting to BeamSqlLine.java to resolve a PreCommit Spotless failure on master introduced in #41257. The changes strictly wrap long comment lines to adhere to the 100-character limit without altering any functional logic.

🔍 General Feedback

  • The formatting adjustments are clean, minimal, and directly address the linter failure.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@damccorm
damccorm marked this pull request as ready for review November 13, 2026 04:13
@damccorm

Copy link
Copy Markdown
Contributor Author

cc/ @ahmedabu98 @talatuyarer

@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.74%. Comparing base (fa1d467) to head (f838177).

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #41261   +/-   ##
=========================================
  Coverage     57.74%   57.74%           
+ Complexity     2634     2633    -1     
=========================================
  Files          1203     1203           
  Lines        171888   171888           
  Branches       2182     2182           
=========================================
+ Hits          99256    99259    +3     
+ Misses        69973    69969    -4     
- Partials       2659     2660    +1     
Flag Coverage Δ
java 65.44% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm
damccorm merged commit d7d31e9 into master Nov 13, 2026
27 checks passed
@damccorm
damccorm deleted the fix/beam-sql-line-spotless branch November 13, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extensions java size/xs XS: <10 lines changed sql test-failure-cleanup Automated test health and flake cleanup PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants