Skip to content

Sleep between create_stream retry attempts when waiting for LocalStack in Kinesis ITs #41204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
damccorm wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −0
Draft

Sleep between create_stream retry attempts when waiting for LocalStack in Kinesis ITs #41204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6c69ea
Sleep between create_stream retry attempts when waiting for LocalStac…
damccorm Nov 11, 2026
8cc143c
Keep retries=10 and post-create sleep, add comment on except sleep
damccorm Nov 13, 2026
604a5e8
Merge remote-tracking branch 'upstream/master' into fix/kinesis-it-lo…
damccorm Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdks/python/apache_beam/io/external/xlang_kinesisio_it_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,10 @@ def create_stream(self, stream_name):
if i == retries - 1:
logging.error('Could not create kinesis stream')
raise e
# LocalStack's HTTP endpoint may not be ready to accept connections
# immediately after container startup; sleep before retrying so all
# attempts are not exhausted immediately on ConnectionClosedError.
time.sleep(3)

# Wait for the stream to be active
self.get_first_shard_id(stream_name)
Expand Down
4 changes: 4 additions & 0 deletions sdks/python/apache_beam/yaml/integration_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,10 @@ def _create_kinesis_stream(kinesis_client, stream_name):
if attempt == retries - 1:
_LOGGER.error('Could not create kinesis stream')
raise exn
# LocalStack's HTTP endpoint may not be ready to accept connections
# immediately after container startup; sleep before retrying so all
# attempts are not exhausted immediately on ConnectionClosedError.
time.sleep(3)

for attempt in range(retries):
stream = kinesis_client.describe_stream(StreamName=stream_name)
Expand Down
Loading