Repository navigation
[IcebergIO] Fix partition values written by hash distribution - #41012
Open
ahmedabu98 wants to merge 3 commits into
Open
ahmedabu98 wants to merge 3 commits into
ahmedabu98 wants to merge 3 commits into
Conversation
Contributor
|
Assigning reviewers: R: @chamikaramj for label iceberg. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41012 +/- ##
=========================================
Coverage 58.25% 58.25%
Complexity 2277 2277
=========================================
Files 1136 1136
Lines 169341 169341
Branches 1482 1482
=========================================
Hits 98647 98647
Misses 68146 68146
Partials 2548 2548 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Reminder, please take a look at this pr: @chamikaramj |
…ition-values Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use RecordWriterManager to write through the HASH distribution mode. RecordWriterManager determines a destination file's partition from its rows instead of an incoming partition path. Using the parsed partition path directly resulted in some errors:
yearpartitions stored the calendar year instead of years since 1970 (2024 instead of 54).a b/cbecamea+b%2Fc)."null", so it shared a partition with real"null"values.false.year,month,dayandhourpartitions, crashed the write.Added tests to make sure these are covered against future changes.
RecordWriterManager now numbers files per partition path, so a null and the string “null” no longer write the same file.
Also fixed Timestamp.MICROS, which used to crash.