Skip to content

Move BundleLifter from Iceberg to sdk/util #40978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmedabu98 merged 1 commit into from
Nov 10, 2026
Merged

Move BundleLifter from Iceberg to sdk/util #40978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...che/beam/sdk/io/iceberg/BundleLifter.java → ...rg/apache/beam/sdk/util/BundleLifter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.beam.sdk.io.iceberg;
package org.apache.beam.sdk.util;

import static org.apache.beam.sdk.util.Preconditions.checkArgumentNotNull;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.util.ArrayList;
import java.util.List;
import org.apache.beam.sdk.annotations.Internal;
import org.apache.beam.sdk.transforms.DoFn;
import org.apache.beam.sdk.transforms.DoFn.MultiOutputReceiver;
import org.apache.beam.sdk.transforms.DoFn.OutputReceiver;
Expand All @@ -41,8 +42,11 @@
* A PTransform that buffers elements and outputs them to one of two TupleTags based on the total
* size of the bundle in finish_bundle.
*
* <p>For internal use only; no backwards-compatibility guarantees.
*
* @param <T> The type of elements in the input PCollection.
*/
@Internal
@SuppressFBWarnings(
value = "CT_CONSTRUCTOR_THROW",
justification =
Expand Down
4 changes: 2 additions & 2 deletions ...beam/sdk/io/iceberg/BundleLifterTest.java → ...pache/beam/sdk/util/BundleLifterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.beam.sdk.io.iceberg;
package org.apache.beam.sdk.util;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.containsInAnyOrder;
import static org.hamcrest.Matchers.empty;

import org.apache.beam.sdk.io.iceberg.BundleLifter.BundleLiftDoFn;
import org.apache.beam.sdk.transforms.DoFnTester;
import org.apache.beam.sdk.util.BundleLifter.BundleLiftDoFn;
import org.apache.beam.sdk.values.TupleTag;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand Down
1 change: 1 addition & 0 deletions sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteToDestinations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.apache.beam.sdk.transforms.windowing.GlobalWindows;
import org.apache.beam.sdk.transforms.windowing.Repeatedly;
import org.apache.beam.sdk.transforms.windowing.Window;
import org.apache.beam.sdk.util.BundleLifter;
import org.apache.beam.sdk.util.ShardedKey;
import org.apache.beam.sdk.values.KV;
import org.apache.beam.sdk.values.PCollection;
Expand Down
Loading