-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[Spark][#36841] Translate stateless streaming pipelines on the Spark 4 runner #40090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tkaymak
wants to merge
1
commit into
apache:master
Choose a base branch
from
tkaymak:spark4-streaming-slice4-translator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
.../apache/beam/runners/spark/structuredstreaming/translation/PipelineTranslatorFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.runners.spark.structuredstreaming.translation; | ||
|
|
||
| import org.apache.beam.runners.spark.structuredstreaming.translation.batch.PipelineTranslatorBatch; | ||
| import org.apache.beam.sdk.annotations.Internal; | ||
|
|
||
| /** | ||
| * This class shadows the shared base file of the same name. The Spark 4 module compiles the | ||
| * override tree with later wins, so this copy replaces the base one that throws for streaming. | ||
| */ | ||
| @Internal | ||
| public final class PipelineTranslatorFactory { | ||
| private PipelineTranslatorFactory() {} | ||
|
|
||
| /** Creates a {@link PipelineTranslator} for the given execution mode. */ | ||
| public static PipelineTranslator create(boolean streaming) { | ||
| return streaming ? new PipelineTranslatorStreaming() : new PipelineTranslatorBatch(); | ||
| } | ||
| } |
106 changes: 106 additions & 0 deletions
106
...pache/beam/runners/spark/structuredstreaming/translation/PipelineTranslatorStreaming.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.runners.spark.structuredstreaming.translation; | ||
|
|
||
| import java.util.Collection; | ||
| import org.apache.beam.runners.spark.SparkCommonPipelineOptions; | ||
| import org.apache.beam.runners.spark.structuredstreaming.translation.batch.PipelineTranslatorBatch; | ||
| import org.apache.beam.runners.spark.structuredstreaming.translation.streaming.ReadUnboundedTranslator; | ||
| import org.apache.beam.sdk.annotations.Internal; | ||
| import org.apache.beam.sdk.transforms.Combine; | ||
| import org.apache.beam.sdk.transforms.GroupByKey; | ||
| import org.apache.beam.sdk.transforms.Impulse; | ||
| import org.apache.beam.sdk.transforms.PTransform; | ||
| import org.apache.beam.sdk.transforms.ParDo; | ||
| import org.apache.beam.sdk.transforms.reflect.DoFnSignature; | ||
| import org.apache.beam.sdk.transforms.reflect.DoFnSignatures; | ||
| import org.apache.beam.sdk.util.construction.SplittableParDo; | ||
| import org.apache.beam.sdk.values.PInput; | ||
| import org.apache.beam.sdk.values.POutput; | ||
| import org.apache.spark.sql.SparkSession; | ||
| import org.checkerframework.checker.nullness.qual.Nullable; | ||
|
|
||
| /** | ||
| * Pipeline translator for streaming pipelines on Spark 4. It extends the batch translator to reuse | ||
| * the stateless single output ParDo, Window.Assign, Flatten and Reshuffle translators, which are | ||
| * safe on a streaming Dataset. Every other primitive fails at translation, the batch translators | ||
| * for them persist or collect the Dataset, which Spark rejects for streaming plans. | ||
| */ | ||
| @Internal | ||
| public class PipelineTranslatorStreaming extends PipelineTranslatorBatch { | ||
|
|
||
| /** Returns a {@link TransformTranslator} for the given {@link PTransform} if known. */ | ||
| @Override | ||
| @SuppressWarnings({"rawtypes", "unchecked"}) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please clean up SuppressWarnings |
||
| @Nullable | ||
| protected <InT extends PInput, OutT extends POutput, TransformT extends PTransform<InT, OutT>> | ||
| TransformTranslator<InT, OutT, TransformT> getTransformTranslator(TransformT transform) { | ||
|
|
||
| if (transform instanceof SplittableParDo.PrimitiveUnboundedRead) { | ||
| return (TransformTranslator) new ReadUnboundedTranslator<>(); | ||
| } | ||
|
|
||
| if (transform instanceof SplittableParDo.PrimitiveBoundedRead) { | ||
| throw unsupported( | ||
| "Bounded Read (Read.from(BoundedSource), Create with two or more elements)"); | ||
| } | ||
|
|
||
| if (transform instanceof Impulse) { | ||
| throw unsupported("Impulse (Create with fewer than two elements, PAssert)"); | ||
| } | ||
|
|
||
| if (transform instanceof GroupByKey) { | ||
| throw unsupported("GroupByKey"); | ||
| } | ||
|
|
||
| if (transform instanceof Combine.PerKey) { | ||
| throw unsupported("Combine.perKey"); | ||
| } | ||
|
|
||
| if (transform instanceof ParDo.MultiOutput) { | ||
| ParDo.MultiOutput<?, ?> parDo = (ParDo.MultiOutput<?, ?>) transform; | ||
| DoFnSignature signature = DoFnSignatures.signatureForDoFn(parDo.getFn()); | ||
| if (signature.usesState() || signature.usesTimers()) { | ||
| throw unsupported("Stateful ParDo (" + signature.fnClass().getName() + ")"); | ||
| } | ||
| if (!parDo.getSideInputs().isEmpty()) { | ||
| throw unsupported("ParDo with side inputs (" + signature.fnClass().getName() + ")"); | ||
| } | ||
| if (!parDo.getAdditionalOutputTags().getAll().isEmpty()) { | ||
| throw unsupported("ParDo with additional outputs (" + signature.fnClass().getName() + ")"); | ||
| } | ||
| } | ||
|
|
||
| return super.getTransformTranslator(transform); | ||
| } | ||
|
|
||
| private static UnsupportedOperationException unsupported(String what) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a thin wrapper. In convention exceptions should be created at the exact moment an error occurs. |
||
| return new UnsupportedOperationException( | ||
| what | ||
| + " is not supported by the Spark 4 streaming runner yet, see" | ||
| + " https://github.com/apache/beam/issues/36841"); | ||
| } | ||
|
|
||
| @Override | ||
| protected EvaluationContext createEvaluationContext( | ||
| Collection<? extends EvaluationContext.NamedDataset<?>> leaves, | ||
| SparkSession session, | ||
| SparkCommonPipelineOptions options) { | ||
| return new StreamingEvaluationContext(leaves, session, options); | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it works and resuses some code, future change in PipelineTranslatorBatch may result in surprises on streaming path. For example, new translations meant only for batch now silently port to streaming. On the other hand, refactoring it sounds an risky choice either. At minimum can we rename "PipelineTranslatorBatch" to "PipelineTranslatorCommon" and create a thin subclass "PipelineTranslatorBatch" to it?