Warn on failed import of internal BQ client for easier debugging - #40082
Open
jrmccluskey wants to merge 1 commit into
Open
Warn on failed import of internal BQ client for easier debugging#40082jrmccluskey wants to merge 1 commit into
jrmccluskey wants to merge 1 commit into
Conversation
3 tasks
Contributor
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
approved these changes
Sep 10, 2026
| except ImportError: | ||
| logging.warning( | ||
| "apitools not found, and bigquery client libraries are not " | ||
| "available despite the import not raising an ImportError.") |
Contributor
There was a problem hiding this comment.
In an ideal world we'd just throw the exception. I guess this is going away soon anyways, though, so this is probably fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports of the internal BQ client fail if the GCP extras category is not installed; however, the init.py file for the internal client was written to swallow ImportErrors. This made it hard to debug unit tests that carry that dependency, as the import of the package would silently fail and underlying types would not be available to use.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.