Revert "[Python] Honor disableCounterMetrics, disableStringSetMetrics, and disableBoundedTrieMetrics experiments" - #38901
Conversation
…, and di…" This reverts commit c01ceea.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous change that allowed users to disable specific metric types (Counter, StringSet, and BoundedTrie) via pipeline experiments. The reversion was necessary to resolve issues with internal imports and other breakages caused by the original implementation. The codebase has been cleaned up to remove the Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
R: @damccorm |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the MetricsFlag class and the associated logic for disabling specific metric types (counters, string sets, and bounded tries) via pipeline options, simplifying the delegating metric classes. A review comment identifies an incorrect docstring in DelegatingBoundedTrie that refers to StringSet instead of BoundedTrie.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
…, and disableBoundedTrieMetrics experiments" (apache#38901) * Revert "[Python] Honor disableCounterMetrics, disableStringSetMetrics, and di…" This reverts commit c01ceea. * Apply suggestions from code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ableBoundedTrieMetrics experiments Re-lands the feature from apache#38749 (reverted in apache#38901) without changing the public surface of the metric objects. The Java SDK lets high throughput jobs turn off metric kinds that pressure the metrics backend via these experiments; the Python SDK now does the same. Instead of replacing DelegatingCounter.inc / DelegatingStringSet.add / DelegatingBoundedTrie.add with methods (which broke callers passing the value as a keyword and code relying on them being MetricUpdater instances), the gate lives in MetricUpdater.__call__ and is keyed by cell type. With no experiment set it is a truthiness check on an empty set, so the hot path is unchanged. MetricsFlag.set_default_pipeline_options mirrors the Java MetricsFlag and is applied when a Pipeline is constructed and at SDK worker harness start-up, first call wins as in Java. Fixes apache#38746 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2 participants
Reverts #38749
See #38749 (comment), and there are other breakages breaking internal imports