Repository navigation
Conversation
NodeImpl.cc::escape() emitted a raw 0x0c byte instead of \f when serializing schema doc strings and string default values, producing invalid JSON (RFC 8259 section 7) in Avro file headers and serialized schemas whenever a string contained a form-feed character.
Member
Author
|
Tagging for reviews: @martin-g |
Member
Author
|
Tagging for reviews: @Fokko |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
escape()inlang/c++/impl/NodeImpl.ccemits a raw0x0cbyte (s += '\f') instead of\f(s += '\\'; s += 'f';) when serializing schemadocstrings and string default values, whereas\b,\n,\r,\t,\", and\\are all escaped as two-character sequences. Any schema containing a form-feed character therefore serializes to invalid JSON (RFC 8259 section 7) in Avro file headers andtoJson()output.Verifying this change
This change added tests and can be verified as follows:
lang/c++/test/SchemaTests.cc(schemasToCompact/compactSchemas) with both an escaped\\fand a raw\fin a recorddocstring, verifying both serialize to\\fin the compacted JSON schema (fails before the fix and passes with it).Documentation