You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've finally had time to review this in depth. I think this is a good thing to add and it's almost at the point where we can merge it. I've pushed a commit which adds documentation and simplifies the code a bit.
Unfortunately there are 3 tests (which you had marked as should_panic) which I think should work. The issue common to these 3 tests is an (union) enum with only one variant inside an Option. To the serializer code it looks like an Option so it takes the wrong branch at serde/ser_schema/mod.rs:409. As I think this is a common case (there is no serde trickery here with untagged or other attributes) it needs to be fixed before we can merge it (it would be confusing for the user if this case does not work).
I'll therefore put it onto the 0.23 milestone and start thinking about how we can fix this without degrading performance for Options and without requiring more complex code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #517. Original PR at #519