bench(parquet): cover mask-backed intersection/union in row_selector - #10574
Merged
alamb merged 2 commits intoAug 7, 2026
Conversation
The existing `intersection`/`union` benchmarks build their operands with `from_filters`, which is selector-backed, so they take the `RowSelector` merge path and never reach the bitwise one. Add `mask_intersection`/`mask_union` alongside them, varying two dimensions that drive the bitwise path: the ratio between operand lengths, since the longer side's tail passes through unchanged, and the bit offsets the operands carry, since masks come from `BooleanBuffer::slice` and whether the two share a sub-64-bit alignment decides which path the underlying helpers take.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Split out of #10446 so that CI can compare both sides — the benchmark is new there, so the merge-base has nothing to compare against and the
maincolumn comes out empty.Rationale for this change
row_selector.rsalready benchmarksintersection/union, but it builds the operands withfrom_filters, which is selector-backed. Those take theRowSelectormerge path and never reach the bitwise one used when both operands are mask-backed.What changes are included in this PR?
Adds
mask_intersection/mask_union, varying the two dimensions that drive the bitwise path:BooleanBuffer::sliceand whether the two share a sub-64-bit alignment decides which path the underlying helpers takeBenchmark only, no library changes.
Are these changes tested?
N/A — this is a benchmark. It builds and runs on
mainas-is.Are there any user-facing changes?
No.