Use ParseFloat with json.Number in Int64/Uint64 Builders' UnmarshalOne - #475
Use ParseFloat with json.Number in Int64/Uint64 Builders' UnmarshalOne#475loicalleyne wants to merge 2 commits into
Conversation
|
Do we need to do this for ALL the integer types? not just int64/uint64? Can you add a relevant test case for this please? |
|
FWIW, while exploring issues and PRs, I noticed that using ParseFloat isn’t the right solution. The problem is that it loses precision for integers larger than 2^53 (for example, "9007199254740993" gets converted to 9.007199254740993e+15). |
|
@loicalleyne Converting to draft — this PR doesn't yet meet our Pull Request quality criteria.
See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush. Note: This comment was drafted by an AI-assisted triage tool run by a maintainer, and may contain mistakes. Once you have addressed the points above, an Apache Arrow Go maintainer — a real person — will take the next look at your PR. If anything here looks wrong, say so on the PR and a maintainer will follow up. See CONTRIBUTING.md for the project's contribution conventions. |
Rationale for this change
Addresses #474
What changes are included in this PR?
Replaced
strconv.ParseInt/strconv.ParseUintwithstrconv.ParseFloatin Int64/Uint64Builder.UnmarshalOneAre these changes tested?
Existing tests pass.
Are there any user-facing changes?
No