perf(parquet): decode nullable plain values into valid runs - #1314
Open
fallintoplace wants to merge 1 commit into
Open
fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
PlainDecoder.DecodeSpacedused to decode all non-null values into a dense prefix first, then move them into their bitmap positions.Benchmark
Apple M1 Pro, Go 1.26.3, 65,536
int32values, 8 runs, 300ms per sample:Random 10% nulls and alternating validity keep the existing fallback path. All cases stayed at 0 B/op and 0 allocs/op.
Tests
PARQUET_TEST_DATA=parquet-testing/data ARROW_TEST_DATA=arrow-testing/data go test -p 2 ./... -count=1go test -race -p 2 ./parquet/internal/encoding ./parquet/filego vet -p 2 ./parquet/internal/encoding ./parquet/file