perf(arrow/array): append dictionary indices directly - #1313
Open
fallintoplace wants to merge 2 commits into
Open
perf(arrow/array): append dictionary indices directly#1313fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
DictionaryBuilder.AppendIndicesused to allocate a new typed slice on every call.Benchmark
Command:
Apple M1 Pro, Go 1.26.3. The benchmark uses 65,536 indices and a 256-entry dictionary.
This is about 32% less time and allocation bytes for the non-null case, and about 35% less time for the nullable case.
The Parquet decoder's separate
[]uint64 -> []intscratch conversion is intentionally outside this PR.Tests
go test ./...go test -race ./arrow/arraygo vet ./arrow/array