perf(internal/hashing): avoid boxing byte slices in InsertOrGet - #1310
Open
fallintoplace wants to merge 3 commits into
Open
perf(internal/hashing): avoid boxing byte slices in InsertOrGet#1310fallintoplace wants to merge 3 commits into
fallintoplace wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
InsertOrGetalready receives a[]byte.getHash, which acceptsinterface{}and boxed the slice.Hash(val, 0)directly, matching the typed hashing path.Benchmark
The focused
BenchmarkBinaryMemoTableInsertOrGetexercises this exact method with 65,536 lookups over 100 repeated values.Apple M1 Pro, Go 1.26.3:
The old Parquet byte-array benchmark was removed from this description because it uses a separate memo implementation.
Testing
go test ./internal/hashinggo test ./...withPARQUET_TEST_DATAconfigured