Skip to content

chore: Use approved GitHub Actions#60

Open
Benjamin-Philip wants to merge 2 commits into
apache:mainfrom
Benjamin-Philip:bp/pin-actions
Open

chore: Use approved GitHub Actions#60
Benjamin-Philip wants to merge 2 commits into
apache:mainfrom
Benjamin-Philip:bp/pin-actions

Conversation

@Benjamin-Philip

@Benjamin-Philip Benjamin-Philip commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Which issue does this PR close?

Closes #50.

Rationale for this change

The ASF has a list of approved GitHub Actions that are allowed to execute (found here). Unless all actions in a workflow have been approved, the workflow cannot run.

What's Changed

This commit pins certain actions to the approved version so that GitHub Actions can execute.

The ASF has a list of approved GitHub Actions that are allowed to
execute (found here:
https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml)

This commit pins certain actions to the approved version so that GitHub
Actions can execute.
Copilot AI review requested due to automatic review settings June 23, 2026 04:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions workflow definitions to comply with the ASF approved-actions allowlist by pinning previously unpinned actions (e.g., @master / @v1) to specific commit SHAs so workflows are permitted to execute.

Changes:

  • Pin dtolnay/rust-toolchain from @master to a specific commit SHA across workflows.
  • Pin erlef/setup-beam from @v1 to a specific commit SHA where used.
  • Adjust rust-cache action reference casing in one job.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/rust-ci.yml Pins Rust toolchain action to a commit SHA; adjusts rust-cache reference casing in one job.
.github/workflows/erlang-ci.yml Pins Erlang setup and Rust toolchain actions to commit SHAs for CI jobs.
.github/workflows/docs.yml Pins Rust toolchain and Erlang setup actions to commit SHAs for docs generation workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 70 to 73
components: rustfmt

- uses: Swatinem/rust-cache@v2
- uses: swatinem/rust-cache@v2
with:
@Benjamin-Philip Benjamin-Philip changed the title Use approved GitHub Actions chore: Use approved GitHub Actions Jun 23, 2026
@Benjamin-Philip

Copy link
Copy Markdown
Collaborator Author

@kou , could you have a look? Once this is merged, I can start working on #51, #55 and #57.


- name: Install Erlang/OTP
uses: erlef/setup-beam@v1
uses: erlef/setup-beam@fc68ffb90438ef2936bbb3251622353b3dcb2f93

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add # ${TAG_NAME} comment that will be updated automatically by Dependabot:

Suggested change
uses: erlef/setup-beam@fc68ffb90438ef2936bbb3251622353b3dcb2f93
uses: erlef/setup-beam@fc68ffb90438ef2936bbb3251622353b3dcb2f93 # v1.24.0

components: clippy

- uses: Swatinem/rust-cache@v2
- uses: swatinem/rust-cache@v2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use SHA256 here too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use approved GitHub Actions

3 participants