fix(jmx): avoid NPE in ConnectionView.getWireFormatInfo - #2270
Open
arimu1 wants to merge 1 commit into
Open
Conversation
getRemoteWireFormatInfo() can be null before wire-format negotiation completes (or for transports that never set it). Calling toString() on that null caused an NPE when the JMX attribute was read. Return the existing "WireFormatInfo not available" placeholder when the remote WireFormatInfo is missing. Fixes apache#2203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectionView.getWireFormatInfo()calledgetRemoteWireFormatInfo().toString()without a null check.TransportConnection.wireFormatInfois only set after wire-format negotiation, so reading the JMX attribute earlier (or for transports that never set it) threw aNullPointerException.This change returns the existing
"WireFormatInfo not available"placeholder when the remoteWireFormatInfois null, matching the non-TransportConnectionpath.Fixes #2203
Changes
ConnectionView.getWireFormatInfo(): null-safe remoteWireFormatInfohandlingConnectionViewTest: regression coverage for present and null remote infoTest plan
mvn -pl activemq-broker test -Dtest=ConnectionViewTest(JDK 17)testGetWireFormatInfoWhenPresenttestGetWireFormatInfoWhenRemoteInfoNull