common: tools: error: construct error from both enum and errno - #648
Open
mlohvynenko wants to merge 1 commit into
Open
common: tools: error: construct error from both enum and errno#648mlohvynenko wants to merge 1 commit into
mlohvynenko wants to merge 1 commit into
Conversation
mlohvynenko
force-pushed
the
feature_add_err_const
branch
from
August 20, 2026 14:11
230f66c to
af1f7f3
Compare
al1img
approved these changes
Aug 21, 2026
al1img
left a comment
al1img
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
This patch adds a constructor to the Error class that allows constructing an Error object from both an ErrorEnum and an errno value. It is useful when an error is constructed from a gRPC response, for example, when the gRPC response contains both an AOS error code and an exit code (errno). Otherwise, there is no way to propagate both error codes to the Error object, and one of them would be lost. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
mlohvynenko
force-pushed
the
feature_add_err_const
branch
from
August 26, 2026 06:30
af1f7f3 to
cfc0b1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a constructor to the Error class that allows constructing an Error object from both an ErrorEnum and an errno value.
It is useful when an error is constructed from a gRPC response, for example, when the gRPC response contains both an AOS error code and an exit code (errno).
Otherwise, there is no way to propagate both error codes to the Error object, and one of them would be lost.