Fix honda findings related to CA certificates

.github/workflows/build-release.yaml

@@ -35,7 +35,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
         with:
           fetch-depth: 0
 

.github/workflows/build-test.yaml

@@ -36,11 +36,12 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
         with:
           ref: ${{github.event.pull_request.head.ref}}
           repository: ${{github.event.pull_request.head.repo.full_name}}
           fetch-depth: 0
+          allow-unsafe-pr-checkout: true
 
       - name: Install build wrapper
         uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v7
@@ -54,6 +55,7 @@ jobs:
           ./build.sh coverage
 
       - name: Upload codecov report
+        if: github.event_name == 'push'
         uses: codecov/codecov-action@v5
         with:
           token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/check-format.yaml

@@ -18,7 +18,7 @@ jobs:
     name: Formatting Check
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v7
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip

.github/workflows/docker-build.yml

@@ -24,7 +24,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: Log in to github container registry
         uses: docker/login-action@v3

.github/workflows/lint.yaml

@@ -35,7 +35,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
         with:
           fetch-depth: 0
 

README.md

@@ -1,7 +1,14 @@
 <!-- markdownlint-disable-next-line MD041 -->
-[![ci](https://github.com/aosedge/aos_core_lib_cpp/actions/workflows/build_test.yaml/badge.svg)](https://github.com/aosedge/aos_core_lib_cpp/actions/workflows/build_test.yaml)
-[![codecov](https://codecov.io/gh/aosedge/aos_core_lib_cpp/graph/badge.svg?token=kg8h7ATd9S)](https://codecov.io/gh/aosedge/aos_core_lib_cpp)
-[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=aosedge_aos_core_lib_cpp&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=aosedge_aos_core_lib_cpp)
+[![ci][ci-dev]][ci-dev-link]
+[![coverage][cov-dev]][cov-dev-link]
+[![Quality Gate][qg-dev]][qg-dev-link]
+
+[ci-dev]: https://github.com/aosedge/aos_core_lib_cpp/actions/workflows/build-test.yaml/badge.svg?branch=develop
+[ci-dev-link]: https://github.com/aosedge/aos_core_lib_cpp/actions/workflows/build-test.yaml?query=branch%3Adevelop
+[cov-dev]: https://sonarcloud.io/api/project_badges/measure?project=aosedge_aos_core_lib_cpp&metric=coverage&branch=develop
+[cov-dev-link]: https://sonarcloud.io/summary/new_code?id=aosedge_aos_core_lib_cpp&branch=develop
+[qg-dev]: https://sonarcloud.io/api/project_badges/measure?project=aosedge_aos_core_lib_cpp&metric=alert_status&branch=develop
+[qg-dev-link]: https://sonarcloud.io/summary/new_code?id=aosedge_aos_core_lib_cpp&branch=develop
 
 # Aos core cpp libraries
 

codecov.yml

@@ -0,0 +1,21 @@
+codecov:
+  branch: main
+
+coverage:
+  status:
+    project:
+      default:
+        target: auto
+        threshold: 1%
+        informational: true
+    patch:
+      default:
+        target: 80%
+        informational: true
+
+ignore:
+  - "**/tests/**"
+
+branches:
+  - main
+  - develop

src/core/cm/alerts/alerts.cpp

@@ -44,11 +44,12 @@ class SetTimestamp : public StaticVisitor<void> {
  * Public
  **********************************************************************************************************************/
 
-Error Alerts::Init(
-    const alerts::Config& config, cm::alerts::SenderItf& sender, cloudconnection::CloudConnectionItf& cloudConnection)
+Error Alerts::Init(AllocatorItf& allocator, const alerts::Config& config, cm::alerts::SenderItf& sender,
+    cloudconnection::CloudConnectionItf& cloudConnection)
 {
     LOG_DBG() << "Init alerts" << Log::Field("sendPeriod", config.mSendPeriod);
 
+    mAllocator       = &allocator;
     mConfig          = config;
     mSender          = &sender;
     mCloudConnection = &cloudConnection;
@@ -102,7 +103,7 @@ Error Alerts::Stop()
         err = AOS_ERROR_WRAP(unsubscribeErr);
     }
 
-    if (auto stopErr = mSendTimer.Stop(); !stopErr.IsNone()) {
+    if (auto stopErr = mSendTimer.Stop(Timer::StopMode::WaitForCallbacks); !stopErr.IsNone()) {
         LOG_ERR() << "Failed to stop alerts send timer" << Log::Field(stopErr);
 
         if (err.IsNone()) {
@@ -186,8 +187,8 @@ Error Alerts::UnsubscribeListener(AlertsListenerItf& listener)
 
     size_t removed = 0;
 
-    for (auto& [tag, listeners] : mListeners) {
-        removed += listeners.Remove(&listener);
+    for (auto& item : mListeners) {
+        removed += item.mSecond.Remove(&listener);
     }
 
     return removed > 0 ? ErrorEnum::eNone : ErrorEnum::eNotFound;
@@ -242,6 +243,9 @@ Error Alerts::SendAlerts()
 
     while (!mAlerts.IsEmpty()) {
         auto package = CreatePackage();
+        if (!package) {
+            return AOS_ERROR_WRAP(ErrorEnum::eNoMemory);
+        }
 
         LOG_INF() << "Send alerts" << Log::Field("alertsCount", package->mItems.Size());
 
@@ -257,7 +261,12 @@ Error Alerts::SendAlerts()
 
 bool Alerts::IsDuplicated(const AlertVariant& alert)
 {
-    auto alertCopy = MakeUnique<AlertVariant>(&mAllocator, alert);
+    auto alertCopy = MakeUnique<AlertVariant>(mAllocator, alert);
+    if (!alertCopy) {
+        LOG_ERR() << "Can't allocate alert copy" << Log::Field(ErrorEnum::eNoMemory);
+
+        return false;
+    }
 
     return mAlerts.FindIf([&alertCopy](const AlertVariant& item) {
         alertCopy->ApplyVisitor(SetTimestamp(item.ApplyVisitor(GetTimestamp())));
@@ -268,7 +277,12 @@ bool Alerts::IsDuplicated(const AlertVariant& alert)
 
 UniquePtr<aos::Alerts> Alerts::CreatePackage()
 {
-    auto package = MakeUnique<aos::Alerts>(&mAllocator);
+    auto package = MakeUnique<aos::Alerts>(mAllocator);
+    if (!package) {
+        LOG_ERR() << "Can't allocate alerts package" << Log::Field(ErrorEnum::eNoMemory);
+
+        return package;
+    }
 
     const auto count = Min<size_t>(cAlertItemsCount, mAlerts.Size());
 

src/core/cm/alerts/alerts.hpp

@@ -40,12 +40,13 @@ class Alerts : public ReceiverItf,
     /**
      * Initializes alerts.
      *
+     * @param allocator allocator to use for temporary objects.
      * @param config configuration object.
      * @param sender alerts sender object.
      * @param cloudConnection cloud connection.
      * @return Error.
      */
-    Error Init(const alerts::Config& config, cm::alerts::SenderItf& sender,
+    Error Init(AllocatorItf& allocator, const alerts::Config& config, cm::alerts::SenderItf& sender,
         cloudconnection::CloudConnectionItf& cloudConnection);
 
     /**
@@ -96,7 +97,6 @@ class Alerts : public ReceiverItf,
     Error UnsubscribeListener(AlertsListenerItf& listener) override;
 
 private:
-    static constexpr auto cAllocatorSize     = sizeof(AlertVariant) + sizeof(aos::Alerts);
     static constexpr auto cListenersMaxCount = 4;
     static constexpr auto cAlertTagsCount    = static_cast<size_t>(AlertTagEnum::eNumAlertTags);
 
@@ -111,7 +111,7 @@ class Alerts : public ReceiverItf,
     void                   ShrinkCache(size_t count);
     void                   NotifyListeners(const AlertVariant& alert);
 
-    StaticAllocator<cAllocatorSize>                      mAllocator;
+    AllocatorItf*                                        mAllocator {};
     alerts::Config                                       mConfig;
     cm::alerts::SenderItf*                               mSender {};
     cloudconnection::CloudConnectionItf*                 mCloudConnection {};

src/core/cm/alerts/tests/alerts.cpp

@@ -16,6 +16,7 @@
 #include <core/common/tests/mocks/cloudconnectionmock.hpp>
 #include <core/common/tests/utils/log.hpp>
 #include <core/common/tests/utils/utils.hpp>
+#include <core/common/tools/heapallocator.hpp>
 
 #include <core/cm/alerts/alerts.hpp>
 
@@ -125,6 +126,10 @@ class AlertsTest : public Test {
 protected:
     void SetUp() override { tests::utils::InitLog(); }
 
+    // mAllocator must be declared (and therefore destroyed) after any member that allocates from it, since
+    // members are destroyed in reverse declaration order.
+    HeapAllocator mAllocator;
+
     alerts::Config                       mConfig {Time::cSeconds * 1};
     SenderStub                           mCommunication;
     cloudconnection::CloudConnectionMock mCloudConnection;
@@ -159,7 +164,7 @@ TEST_F(AlertsTest, DuplicatesAreSkipped)
             return ErrorEnum::eNone;
         }));
 
-    auto err = mAlerts->Init(mConfig, mCommunication, mCloudConnection);
+    auto err = mAlerts->Init(mAllocator, mConfig, mCommunication, mCloudConnection);
     ASSERT_TRUE(err.IsNone()) << tests::utils::ErrorToStr(err);
 
     err = mAlerts->Start();
@@ -198,16 +203,16 @@ TEST_F(AlertsTest, AlertIsSkippedIfBufferIsFull)
 
     std::string message;
 
+    auto err = mAlerts->Init(mAllocator, mConfig, mCommunication, mCloudConnection);
+    ASSERT_TRUE(err.IsNone()) << tests::utils::ErrorToStr(err);
+
     for (size_t i = 0; i < cAlertsCacheSize; ++i) {
         auto alert = CreateCoreAlert(cTime, "node1", std::to_string(i));
 
-        auto err = mAlerts->OnAlertReceived(*alert);
+        err = mAlerts->OnAlertReceived(*alert);
         EXPECT_TRUE(err.IsNone()) << tests::utils::ErrorToStr(err);
     }
 
-    auto err = mAlerts->Init(mConfig, mCommunication, mCloudConnection);
-    ASSERT_TRUE(err.IsNone()) << tests::utils::ErrorToStr(err);
-
     err = mAlerts->OnAlertReceived(*CreateCoreAlert(cTime, "node1", "skipped alert"));
     EXPECT_TRUE(err.IsNone()) << tests::utils::ErrorToStr(err);
 
@@ -264,7 +269,7 @@ TEST_F(AlertsTest, PackagesAreSent)
 
     mConfig.mSendPeriod = Time::cSeconds * 3;
 
-    auto err = mAlerts->Init(mConfig, mCommunication, mCloudConnection);
+    auto err = mAlerts->Init(mAllocator, mConfig, mCommunication, mCloudConnection);
     ASSERT_TRUE(err.IsNone()) << tests::utils::ErrorToStr(err);
 
     err = mAlerts->Start();
@@ -311,7 +316,7 @@ TEST_F(AlertsTest, PackagesAreSentOnReconnect)
 
     std::vector<aos::Alerts> receivedPackages;
 
-    auto err = mAlerts->Init(mConfig, mCommunication, mCloudConnection);
+    auto err = mAlerts->Init(mAllocator, mConfig, mCommunication, mCloudConnection);
     ASSERT_TRUE(err.IsNone()) << tests::utils::ErrorToStr(err);
 
     err = mAlerts->Start();
@@ -353,7 +358,7 @@ TEST_F(AlertsTest, ListenersAreNotified)
         AlertTagEnum::eCoreAlert,
     };
 
-    auto err = mAlerts->Init(mConfig, mCommunication, mCloudConnection);
+    auto err = mAlerts->Init(mAllocator, mConfig, mCommunication, mCloudConnection);
     ASSERT_TRUE(err.IsNone()) << tests::utils::ErrorToStr(err);
 
     err = mAlerts->SubscribeListener(

src/core/cm/config.hpp

@@ -25,7 +25,7 @@
  * Alerts cache size.
  */
 #ifndef AOS_CONFIG_CM_ALERTS_CACHE_SIZE
-#define AOS_CONFIG_CM_ALERTS_CACHE_SIZE 32
+#define AOS_CONFIG_CM_ALERTS_CACHE_SIZE 64
 #endif
 
 /**