Fix sonar errors - #632
Open
mykola-kobets-epam wants to merge 9 commits into
Open
Conversation
al1img
reviewed
Jul 30, 2026
|
|
||
| State(State&&) = default; | ||
| State& operator=(State&&) = default; | ||
| State(State&&) noexcept = default; |
Collaborator
There was a problem hiding this comment.
Remove . at the end of commit message
| } | ||
|
|
||
| digest = it->mIndexDigest; | ||
| digest = it->mIndexDigest; // NOSONAR cpp:S5912 - Assign stays within StaticString capacity |
Collaborator
There was a problem hiding this comment.
Need to find another solution.
Collaborator
Author
There was a problem hiding this comment.
replaced with Assign in some cases
mlohvynenko
reviewed
Jul 30, 2026
| pin.Clear(); | ||
|
|
||
| srand(::time(nullptr)); // use current time as seed for random generator | ||
| srand(::time(nullptr)); // NOSONAR cpp:S5020 - C++ <random> not available in this codebase |
Member
There was a problem hiding this comment.
Can randomItf be used instead?
Collaborator
Author
There was a problem hiding this comment.
yes, fixed
mlohvynenko
reviewed
Jul 30, 2026
| } | ||
|
|
||
| path = fs::JoinPath(mConfig.mImagePath, cLayersFolder, alg, hash); | ||
| path = fs::JoinPath( |
Member
There was a problem hiding this comment.
new Sonar issue?
Use pointer or reference to avoid slicing from "StaticString<512>" to "String".
mykola-kobets-epam
force-pushed
the
fix-sonar-errors
branch
2 times, most recently
from
August 5, 2026 10:26
883ccea to
555fe27
Compare
Make sure that moving an objectis "noexcept" Move and swap operations should be "noexcept" Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Use pointer or reference to avoid slicing Suppress false-positive slicing for String/Array views over Static* Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Replace "module" with another name Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Replace "srand"/"rand" with the facilities in <random> Suppress: C++ <random> not available in this codebase Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Suppress false-positive lock already acquired / lock order reversal Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Use the value returned from the function Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Replace this builtin type with an alias that makes the type size explicit Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
Make an overloaded operator a hidden friend Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
mykola-kobets-epam
force-pushed
the
fix-sonar-errors
branch
from
August 19, 2026 08:20
825cbf9 to
8b8ce92
Compare
|
al1img
reviewed
Aug 21, 2026
| version = it->mVersion; | ||
|
|
||
| return ErrorEnum::eNone; | ||
| return AOS_ERROR_WRAP(version.Assign(it->mVersion)); |
Collaborator
There was a problem hiding this comment.
I don't like to put operators into macro. Should be:
if (auto err = version.Assign(it->mVersion); !err.IsNone()) {
return AOS_ERROR_WRAP(err);
}
reuturn ErrorEnum::eNone;In all the cases.
| } | ||
|
|
||
| return ErrorEnum::eNone; | ||
| return AOS_ERROR_WRAP(pin.ByteArrayToHex(buffer)); |
| const auto count = Min<size_t>(cAlertItemsCount, mAlerts.Size()); | ||
|
|
||
| package->mItems.Assign(Array<AlertVariant>(mAlerts.begin(), count)); | ||
| (void)package->mItems.Assign(Array<AlertVariant>(mAlerts.begin(), count)); |
| void Alerts::ShrinkCache(size_t count) | ||
| { | ||
| mAlerts.Erase(mAlerts.begin(), mAlerts.begin() + Min<size_t>(count, mAlerts.Size())); | ||
| (void)mAlerts.Erase(mAlerts.begin(), mAlerts.begin() + Min<size_t>(count, mAlerts.Size())); |
| } | ||
|
|
||
| receiver->OnAlertReceived(alert); | ||
| (void)receiver->OnAlertReceived(alert); |
|
|
||
| mCancel = true; | ||
| mCondVar.NotifyAll(); | ||
| (void)mCondVar.NotifyAll(); |
| UniqueLock<Mutex> lock(mMutex); // NOSONAR cpp:S5486 - false positive; lock released before next WaitForStop() | ||
|
|
||
| mCondVar.Wait(lock, cRetryTimeout, [this]() { return mCancel; }); | ||
| (void)mCondVar.Wait(lock, cRetryTimeout, [this]() { return mCancel; }); |
Collaborator
There was a problem hiding this comment.
ditto in all the cases:
either return or log error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.