Repository navigation
ci(release): give the preflight step pyyaml (ubuntu-26.04 runners lack it) - #911
Merged
Merged
Conversation
…longer provide it uv run --no-project layers --with packages over the runner's interpreter. ubuntu-24.04's system Python 3.12 shipped PyYAML, so scripts.check_metadata's import yaml worked by accident; ubuntu-26.04 has no system 3.12, uv downloads a bare CPython and the preflight dies with ModuleNotFoundError. Adds a test that every third-party import reachable from scripts.release_preflight is declared with --with on that step. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Parse --with=X, comma lists and version specifiers; follow `from scripts import X`; explicit assertion when the step is missing. Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
57abecd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2b123497.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-release-preflight-pyyaml.simple-module-python.pages.dev |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preflightwithModuleNotFoundError: No module named 'yaml'.uv run --no-project --with tomlkitlayers packages over the runner's interpreter. The last good run (Nov 6) was on ubuntu-24.04, where the system Python 3.12 shipped PyYAML.ubuntu-latestis now ubuntu-26.04, which has no system 3.12, so uv downloads a bare CPython, and theimport yamlinscripts/check_metadata.pyfails. No repo change caused it.--with pyyamlto the preflight step.scripts/tests/test_scripts_release_preflight_deps.py, walks the imports reachable fromscripts.release_preflightand requires every third-party import to be declared with--with. The test fails if--with pyyamlis removed.Verification
--isolated --python-preference only-managed): the old command raises the sameModuleNotFoundError, and the new command exits 0 against PyPI.make lintpasses,make test-pyhas 8324 passed and 28 skipped,make test-jshas 906 passed.from scripts import Xfix are in.CI-only change, so there is no CHANGELOG entry.
Test plan
preflighthttps://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4