Repository navigation
fix(i18n): ship the per-tab catalog sync in @simple-module-py/i18n and use it in the scaffold (#871) - #910
Merged
Conversation
…d use it in the scaffold (#871) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…nc (Codex review) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
cb45677
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://622590af.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issue-871-i18n-header.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host/client_app/i18n.tsinto the published package as@simple-module-py/i18n/inertia.X-SM-I18non every Inertia visit, adopts each non-null catalog, and reloadsi18nonce when the locale changes without a catalog.bootI18nFromInitialPage(i18n)andsubscribeI18nToNavigation(router).I18nRoutertype, so the package doesn't depend on@inertiajs/react.smpy newtemplateapp.tsxboth use it. Scaffolded apps used to keep their own success handler, which sent no header and fell back to the per-session markers.packages/i18n/src/inertia.test.ts. The scaffold regression test now checks the shared wiring.docs/framework/i18n.md,docs/frontend/shared-props.mdanddocs/frontend/performance.md. The CHANGELOG entry tells existing apps how to switch.Closes #871
Verification
tscpasses. A sidebar navigation sendsx-sm-i18n: en:full, and the response carries"messages": null, so the tab keeps its catalog.make lint✓,make ci-docs-build✓,make test-py✓ (8323),make test-js✓ (906).Test plan