Skip to content

fix(host): set path_separator = os in alembic.ini (#872) - #909

Merged
antosubash merged 2 commits into
mainfrom
fix/issue-872-alembic-path-sep
Nov 11, 2026
Merged

antosubash merged 2 commits into
mainfrom
fix/issue-872-alembic-path-sep

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

  • host/alembic.ini and the alembic.ini that smpy new scaffolds now set path_separator = os. Alembic then splits prepend_sys_path and version_locations on the OS path separator.
    • Without the line, a host that adds either option gets a DeprecationWarning on every migration command, and a checkout path with a space is split in two.
    • smpy_modules hit both problems.
  • New framework/cli/tests/test_cli_alembic_ini.py. For each ini, it copies the file into a directory whose name has a space and sets a two-entry prepend_sys_path. It expects no warning, with warnings raised as errors, and two whole paths. It fails without the line.
  • CHANGELOG: an existing app on Alembic 1.16 or newer can add the same line.

Closes #872

Verification

  • make ci-doctor ✓: it migrates and runs alembic check through host/alembic.ini.
  • Local CI: make lint ✓, make test-py ✓ (8323), make test-js ✓ (906).
  • Reviewed by correctness and maintainability reviewers (one CHANGELOG fix) and by Codex, which found nothing.
  • Verification report: https://claude.ai/artifact/J4qmzXpjffc4iHiVjSJnLs

Report links are Claude Artifacts and start private — the author can share them
from claude.ai/code/artifacts if reviewers need access.

Test plan

  • make migrate and make migration still work
  • CI is green

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-11T00:44:54.790105Z 41c40d6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 41c40d6
Status: ✅  Deploy successful!
Preview URL: https://84718408.simple-module-python.pages.dev
Branch Preview URL: https://fix-issue-872-alembic-path-s.simple-module-python.pages.dev

View logs

@antosubash
antosubash merged commit a22acd3 into main Nov 11, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

host: alembic.ini lacks path_separator, which warns and breaks on paths with spaces

1 participant