Repository navigation
fix(skills): link the module layout standard on the docs site, not a path the wheel lacks (#875) - #908
Merged
Conversation
…path the wheel lacks (#875) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
6ca320a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc977652.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issue-875-skill-links.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simple-module-creatingandsimple-module-conventionsskills ship insidesimple_module_cli. They now link https://docs.py.simplemodule.dev/module-layout instead of../../docs/module-layout.md, a path that doesn't exist in an installed CLI.framework/cli/tests/test_cli_skill_links.py: every relative link in any Markdown file underskills/must stay insideskills/and exist.mainand passes here.docs/module-layout.mdgains a "Downstream modules" section on how to copy this repo's root-layout test into an app or a standalone module repo:ALLOWED_ROOTandDOMAIN_AREAS;parents[1]fromtests/;Closes #875
Verification
make lint✓,make ci-docs-build✓,make test-py✓ (8321),make test-js✓ (906).Test plan
smpy skills addin an app; the module layout link in the two skills opens the docs page