Skip to content

fix(skills): link the module layout standard on the docs site, not a path the wheel lacks (#875) - #908

Merged
antosubash merged 2 commits into
mainfrom
fix/issue-875-skill-links
Nov 11, 2026
Merged

antosubash merged 2 commits into
mainfrom
fix/issue-875-skill-links

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

  • The simple-module-creating and simple-module-conventions skills ship inside simple_module_cli. They now link https://docs.py.simplemodule.dev/module-layout instead of ../../docs/module-layout.md, a path that doesn't exist in an installed CLI.
  • New framework/cli/tests/test_cli_skill_links.py: every relative link in any Markdown file under skills/ must stay inside skills/ and exist.
    • It covers inline, titled, angle-bracket and reference-style links, and ignores code fences.
    • It fails on main and passes here.
  • docs/module-layout.md gains a "Downstream modules" section on how to copy this repo's root-layout test into an app or a standalone module repo:
    • ALLOWED_ROOT and DOMAIN_AREAS;
    • parents[1] from tests/;
    • the extra path changes a standalone module repo needs.

Closes #875

Verification

  • Local CI: make lint ✓, make ci-docs-build ✓, make test-py ✓ (8321), make test-js ✓ (906).
  • Reviewed by correctness and maintainability reviewers, whose fixes widened the guard and corrected the downstream steps, and by Codex, which found nothing.
  • Verification report: https://claude.ai/artifact/RagJTWxAB5psWb9N9yh12a

Report links are Claude Artifacts and start private — the author can share them
from claude.ai/code/artifacts if reviewers need access.

Test plan

  • smpy skills add in an app; the module layout link in the two skills opens the docs page
  • CI is green

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-11T00:26:58.845929Z 6ca320a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6ca320a
Status: ✅  Deploy successful!
Preview URL: https://dc977652.simple-module-python.pages.dev
Branch Preview URL: https://fix-issue-875-skill-links.simple-module-python.pages.dev

View logs

@antosubash
antosubash merged commit f0f4534 into main Nov 11, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cli: shipped skills link ../../docs/module-layout.md, which the wheel does not include

1 participant