Repository navigation
fix(cli): a fresh app's make dev runs without Vite errors or npm audit findings (#900) - #905
Merged
Merged
Conversation
…h the string-detail behaviour (#900) Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
6a566d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98d4350b.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issue-900-scaffold-vite.simple-module-python.pages.dev |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simple_module_settingswheel no longer shipsui/components/validation-errors.test.ts. That file made a host's Vite dependency scan fail with "Failed to run dependency scan … vitest".modules/settings/tests-js/, where Vitest collects it; it had never run before.detailbehaviour.scripts/check_wheel_contents.py, run bymake ci-build-packages, fails if any built wheel contains a JS/TS*.test.*/*.spec.*file,test-dom.tsxor apage-tests/directory.client_app/vite.config.tsloads under Vite 8's native config loader:import.meta.dirnameand.tsimport extensions, and the templatetsconfig.jsonsetsallowImportingTsExtensions;optimizeDeps.rolldownOptions.resolve.modulesinstead of the deprecatedesbuildOptions.nodePaths, which this repo's host already does.package.jsonof new apps, in both layouts, overridespostcss-selector-parserto^6.1.5, as this repo's root does.@tailwindcss/typography@0.5.20, its latest release, pins the vulnerable 6.0.10.Closes #900
Verification
make dev's Vite starts with no warnings or scan error;vite buildandtscpass;npm install,npm auditfinds 0 vulnerabilities (3 moderate before).make ci-build-packages: 23 clean wheels.main's settings wheel fails the new check.make lint✓,make test-py✓ (8295 passed),make test-js✓ (906 passed).Test plan
smpy new demo -y && cd demo && make dev; Vite prints no warnings, andnpm auditis clean