Skip to content

fix(cli): a fresh app's make dev runs without Vite errors or npm audit findings (#900) - #905

Merged
antosubash merged 6 commits into
mainfrom
fix/issue-900-scaffold-vite
Nov 10, 2026
Merged

antosubash merged 6 commits into
mainfrom
fix/issue-900-scaffold-vite

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

  • The simple_module_settings wheel no longer ships ui/components/validation-errors.test.ts. That file made a host's Vite dependency scan fail with "Failed to run dependency scan … vitest".
    • The test moved to modules/settings/tests-js/, where Vitest collects it; it had never run before.
    • One stale case now matches the intended string-detail behaviour.
  • New scripts/check_wheel_contents.py, run by make ci-build-packages, fails if any built wheel contains a JS/TS *.test.*/*.spec.* file, test-dom.tsx or a page-tests/ directory.
  • The scaffold's client_app/vite.config.ts loads under Vite 8's native config loader:
    • it uses import.meta.dirname and .ts import extensions, and the template tsconfig.json sets allowImportingTsExtensions;
    • it uses optimizeDeps.rolldownOptions.resolve.modules instead of the deprecated esbuildOptions.nodePaths, which this repo's host already does.
  • The root package.json of new apps, in both layouts, overrides postcss-selector-parser to ^6.1.5, as this repo's root does. @tailwindcss/typography@0.5.20, its latest release, pins the vulnerable 6.0.10.

Closes #900

Verification

  • Checked in a scaffolded app on Vite 8.3.7:
    • make dev's Vite starts with no warnings or scan error;
    • vite build and tsc pass;
    • after a fresh npm install, npm audit finds 0 vulnerabilities (3 moderate before).
  • make ci-build-packages: 23 clean wheels. main's settings wheel fails the new check.
  • Local CI: make lint ✓, make test-py ✓ (8295 passed), make test-js ✓ (906 passed).
  • Reviewed in 2 passes of correctness and maintainability reviewers, plus Codex, which found nothing.
  • Verification report: https://claude.ai/artifact/8UapNENbnjjQAESdMcXViN

Report links are Claude Artifacts and start private — the author can share them
from claude.ai/code/artifacts if reviewers need access.

Test plan

  • Run smpy new demo -y && cd demo && make dev; Vite prints no warnings, and npm audit is clean
  • CI is green, including package-build

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6a566d2
Status: ✅  Deploy successful!
Preview URL: https://98d4350b.simple-module-python.pages.dev
Branch Preview URL: https://fix-issue-900-scaffold-vite.simple-module-python.pages.dev

View logs

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-10T23:26:28.095500Z 6a566d2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@antosubash
antosubash merged commit ba5f028 into main Nov 10, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scaffold: make dev on a fresh app prints Vite errors (test file in settings wheel, Vite 8 config warnings)

1 participant