Skip to content

fix(cli): scaffolded module pages render inside the app shell (#897) - #904

Merged
antosubash merged 2 commits into
mainfrom
fix/issue-897-module-layout
Nov 10, 2026
Merged

antosubash merged 2 commits into
mainfrom
fix/issue-897-module-layout

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

  • The Browse, Create and Edit page templates now import AuthenticatedLayout and set <Page>.layout = [AuthenticatedLayout];. This covers both the app variant and the framework-repo overlay, and matches the framework's own module pages. Before, a page from smpy create-module or make new-module rendered with no sidebar, header or footer.
  • docs/frontend/pages.md and the simple-module-inertia-pages skill now say that a page must set its own layout, because the host applies none.
  • The CHANGELOG Fixed entry gives the two-line fix for modules generated earlier.

Closes #897

Verification

  • Browser check by hand in a scaffolded app; this repo's dev app doesn't render the templates.
    • A module generated with the new template: /shelves/ and /shelves/create render inside the app shell.
    • A module generated with the old template, as a control: its pages render bare.
  • The generated module passes tsc --noEmit, and the rendered pages of both variants pass biome check.
  • Local CI:
    • make lint ✓ and make test-js ✓ (900).
    • make test-py: 8279 passed, 2 failed. The 2 failures are the cross-process invalidation timeouts in tests/integration/test_invalidation_cross_process.py, which fail the same way on a clean main checkout under the current machine load.
  • Verification report: https://claude.ai/artifact/9Gk7RKgziPsZ2azBF5Bi7X

Report links are Claude Artifacts and start private — the author can share them
from claude.ai/code/artifacts if reviewers need access.

Test plan

  • smpy create-module x in an app; /x/ shows the sidebar
  • CI is green

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-10T22:57:53.692881Z cb3b157 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb3b157
Status: ✅  Deploy successful!
Preview URL: https://b383f801.simple-module-python.pages.dev
Branch Preview URL: https://fix-issue-897-module-layout.simple-module-python.pages.dev

View logs

@antosubash
antosubash merged commit 9dfa163 into main Nov 10, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scaffold: create-module pages render without the app layout (no sidebar)

1 participant