Repository navigation
fix(cli): scaffolded module pages render inside the app shell (#897) - #904
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
cb3b157
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b383f801.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issue-897-module-layout.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browse,CreateandEditpage templates now importAuthenticatedLayoutand set<Page>.layout = [AuthenticatedLayout];. This covers both the app variant and the framework-repo overlay, and matches the framework's own module pages. Before, a page fromsmpy create-moduleormake new-modulerendered with no sidebar, header or footer.docs/frontend/pages.mdand thesimple-module-inertia-pagesskill now say that a page must set its own layout, because the host applies none.Closes #897
Verification
/shelves/and/shelves/createrender inside the app shell.tsc --noEmit, and the rendered pages of both variants passbiome check.make lint✓ andmake test-js✓ (900).make test-py: 8279 passed, 2 failed. The 2 failures are the cross-process invalidation timeouts intests/integration/test_invalidation_cross_process.py, which fail the same way on a cleanmaincheckout under the current machine load.Test plan
smpy create-module xin an app;/x/shows the sidebar