Skip to content

fix(cli): a fresh smpy new app passes its own make lint (#896) - #903

Merged
antosubash merged 8 commits into
mainfrom
fix/issue-896-scaffold-lint
Nov 10, 2026
Merged

antosubash merged 8 commits into
mainfrom
fix/issue-896-scaffold-lint

Conversation

@antosubash

Copy link
Copy Markdown
Owner

Summary

  • host/alembic.ini (in the scaffold and in this repo) gains a [post_write_hooks] entry. It runs the project's ruff on every new revision: check --select I --fix, then format. The initial-schema revision and every make migration output now pass make lint.
    • The hooks use Alembic's module runner, so simple_module_db and the host template now require alembic>=1.16.3.
    • A standalone smpy create-host project gets a dev group with ruff.
  • create-module renders the module.py constants import in ruff's order for any module name. Before, it was unsorted for names that sort before group, such as bookmarks.
  • The # ty: ignore[invalid-assignment] comment is generated only for modules inside this repo, where ty checks that rule.
  • New apps pin ty>=0.0.90,<0.0.100, because ty 0.0.100 renamed the unresolved-attribute rule. A test fails once this repo's uv.lock moves past the range.

Closes #896

Verification

  • Real check with the branch's CLI and a full install:
    • steps: smpy new bookshelf -y, create-module bookmarks, smpy add, make migration, make lint;
    • result: ruff format, ruff check and ty check (0.0.99) all pass.
    • Before the change: 1 file to reformat, 35 ruff errors and 2 ty warnings.
  • Local CI:
    • make lint ✓, make test-js ✓ (900), make ci-doctor ✓.
    • make test-py: 8277 passed, 2 failed. The 2 failures are in tests/integration/test_invalidation_cross_process.py (httpx ReadTimeout). They fail the same way on a clean main checkout run alone under the current machine load.
  • Reviewed in 3 passes of correctness and maintainability reviewers, plus two Codex reviews. The final one found nothing.
  • Verification report: https://claude.ai/artifact/64JCfRRr2T8ipF9nMoRv41

Report links are Claude Artifacts and start private — the author can share them
from claude.ai/code/artifacts if reviewers need access.

Test plan

  • smpy new demo -y && cd demo && make lint passes
  • CI is green

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-10T22:15:17.653292Z 7e90940 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e90940
Status: ✅  Deploy successful!
Preview URL: https://aecc6d90.simple-module-python.pages.dev
Branch Preview URL: https://fix-issue-896-scaffold-lint.simple-module-python.pages.dev

View logs

@antosubash
antosubash merged commit b43329a into main Nov 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scaffold: a fresh smpy new app fails its own make lint (initial migration, module imports, ty drift)

1 participant