Repository navigation
fix(cli): a fresh smpy new app passes its own make lint (#896) - #903
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
7e90940
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aecc6d90.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issue-896-scaffold-lint.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host/alembic.ini(in the scaffold and in this repo) gains a[post_write_hooks]entry. It runs the project's ruff on every new revision:check --select I --fix, thenformat. The initial-schema revision and everymake migrationoutput now passmake lint.modulerunner, sosimple_module_dband the host template now requirealembic>=1.16.3.smpy create-hostproject gets adevgroup with ruff.create-modulerenders themodule.pyconstants import in ruff's order for any module name. Before, it was unsorted for names that sort beforegroup, such asbookmarks.# ty: ignore[invalid-assignment]comment is generated only for modules inside this repo, where ty checks that rule.ty>=0.0.90,<0.0.100, because ty 0.0.100 renamed theunresolved-attributerule. A test fails once this repo'suv.lockmoves past the range.Closes #896
Verification
smpy new bookshelf -y,create-module bookmarks,smpy add,make migration,make lint;ty check(0.0.99) all pass.make lint✓,make test-js✓ (900),make ci-doctor✓.make test-py: 8277 passed, 2 failed. The 2 failures are intests/integration/test_invalidation_cross_process.py(httpx ReadTimeout). They fail the same way on a cleanmaincheckout run alone under the current machine load.Test plan
smpy new demo -y && cd demo && make lintpasses