Repository navigation
fix(hosting): keep a response's own Content-Security-Policy beside the app policy - #884
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
84fec6a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c8a2e6f8.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-issue-870-response-csp.simple-module-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecurityHeadersMiddlewareno longer overwrites aContent-Security-Policythat a response sets. It keeps every response policy and sends the nonced app policy beside it as a second header. Browsers enforce both, so a page can tighten the policy (for exampleframe-ancestors 'none'on a public page) but never relax it. Before this, only a policy containingsandboxsurvived; any other was dropped silently.sandboxpolicy, so nothing here changes.middleware.md,module-authoring.md,file_storage.md) explain how to make a page stricter, the nonce caveat andX-Frame-Options. The CHANGELOG has a Fixed entry.Closes #870
Verification
framework/hosting/tests/test_hosting_csp_nonce.pycover it. They check that a stricter policy is kept beside the nonced app policy, that two response policies are both kept, that a response without a policy gets one header, and that the existingsandboxand 304 cases still pass.make lint(including typecheck) passes,make test-py8,238 passed andmake test-js900 passed.Test plan
Content-Security-Policy: frame-ancestors 'none'sends two CSP headers, and the page can't be framedhttps://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4