Repository navigation
perf(loadtest,hosting): working Inertia locust harness; validate path prefixes once; batch static security headers - #842
Merged
Conversation
… prefixes once; batch static security headers Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…micro # Conflicts: # CHANGELOG.md
Deploying simple-module-python with
|
| Latest commit: |
a17192f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9eaad1ea.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-s16-perf-harness-micro.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load-test harness fix plus two measured per-request savings. These come from the local performance review of 2026-11-05.
Load-test harness (
tests/loadtest/)X-Inertia-Version, so/dashboard/and/admin/users/got a 409 on every request: 26.5% failures, and those endpoints measured nothing. It also sent noX-SM-I18n, so every response carried the full catalog.data-page. It sendsX-Inertia-VersionandX-SM-I18nthe way the client does, and treats 409 as a failure.tests/loadtest/test_loadtest_inertia_client.py.Per-request micro-optimisations (kept only where a benchmark shows a gain;
scripts/bench_loadtest_overheads.py, numbers intests/loadtest/README.md)matches_pathno longer re-validates prefixes on every call. Callers build their tuples once with the newvalidated_prefixes(...), which keeps the trailing-slash check at import time. That covers rate limit, setup gate, maintenance, observability, auth's public paths and site_lock's health prefix. 0.76 → 0.23 µs per call._security_headers.py, andsimple_module_hosting.middleware.SecurityHeadersMiddlewarestill imports. Full wrapper: 14.4 → 11.4 µs.Pipeline:
matches_path, and the header batch mutated the app's header list.Local CI:
make lint✓ ·make test-py(8 workers) 7885 passed ✓ ·make test-js✓.https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4