Repository navigation
perf(settings,inertia): cache settings source metadata; pre-serialise the i18n catalog - #835
Merged
Merged
Conversation
…ise the i18n catalog Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…ice; env-pinned tests simulate a restart Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
…the stdlib name Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
f7e2698
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4cafb75c.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-s12-perf-settings-inerti.simple-module-python.pages.dev |
…-inertia # Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance fix for two hot paths found by the 2026-11-05 load test.
Settings pages /
GET /api/settings/modulesrebuilt pydantic settings sources (env,.env, secrets dir) for every module settings class on every request.simple_module_core.settings_hydrate.env_supplied_fieldsandsimple_module_hosting._api_version.default_api_versionare cached per class per process..envor the secrets directory now needs a restart. That was already true for the running app's settings; only the settings screen's "set by env" marker and the env-pinned write guard read the live environment before.simple_module_test.process_state) clears both caches around every test. Tests that set env mid-test clear them explicitly to simulate a restart.Inertia page encoding walked and re-encoded the shared i18n catalog (~70–90 KB, static per locale + audience) on every full page load.
JsonSnapshot, insimple_module_inertia._json_snapshotandsimple_module_hosting._i18n_json.props.i18n.messages, skipping_resolve_treeand the plain-JSON walk for it.data-page, escaping included. Partial reloads andX-SM-I18n-matched visits behave as before.Median CPU per operation, 87 KB catalog:
Pipeline: /optimize (1 commit), correctness + maintainability review. Review fixes:
json;.envbefore the cache fills.Local CI:
make lint✓ andmake test-js✓.make test-py(8 workers): one failure, a local stale__pycache__directory left by the merged dashboard module move. It passes once that is removed, and it does not exist in CI.https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4