Repository navigation
fix(audit): redact credential values in audit entries and log events - #826
Merged
Merged
Conversation
Deploying simple-module-python with
|
| Latest commit: |
505e94d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1e1e541.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-s01-audit-redaction.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening: the audit trail and entity log events no longer record credential values.
__audit_redact_fields__(always) and__audit_redact_row__(per-row predicate) insimple_module_db.audit_redaction: the change entry stays, its old/new values become[redacted]. Applied on the ORM flush path, the created snapshot, bulk/Core statement capture and manualrecord_bulk_audit.Setting.value(secret by the same rule as settings masking,simple_module_core.secret_fields.conceals_secret+SENSITIVE_KEYS, now in core),User.hashed_password, OAuth account tokens, session/refresh token models (their primary key is the token, soentity_idis masked too), tenant invitation token hashes, auth refresh outcomes and lease holders.entity-updated/entity-deletedlog events mask credential primary keys.b8d4f2a6c901(audit_log branch) scrubs stored history; it redacts all historical settings values conservatively because old entries lack the key. Downgrade is a no-op.settings.constants.SENSITIVE_KEYS(moved to core). CHANGELOG under Unreleased → Security / Removed; operators should rotate credentials saved through the settings UI on earlier versions.Pipeline: /optimize (1 commit), two review rounds (correctness + maintainability), triage notes kept locally.
Local CI:
make lint✓ ·make test-py(8 workers) 7858 passed ✓ ·make test-js✓ ·make migrations-roundtrip-pg✓.https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4