Repository navigation
ci(release): pass dispatch inputs via env; read-only by default - #824
Merged
Merged
Conversation
… to publishing jobs Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
Deploying simple-module-python with
|
| Latest commit: |
e82a213
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b71b2832.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-s04-release-inputs.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening for the release workflow:
resolvejob readsinputs.version/inputs.bumpfrom stepenv:instead of templating them into the bash source, so the version string is data that the existing regex validates.contents: read. Onlypublish-pypi/publish-npm(OIDCid-token: write) andfinalize(contents: writefor the release commit, tag and GitHub Release) widen it.scripts/tests/test_scripts_release_safety.pypin both rules.Verified: the new tests fail on main and pass here;
scripts/tests217 passed;make lintclean.https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4