Repository navigation
fix(db,audit_log): bulk audit prefetch keeps loader criteria; ORM restores and PK changes are audited - #821
Merged
Merged
Conversation
…estores and PK changes are audited (#810, #811) Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Deploying simple-module-python with
|
| Latest commit: |
315609d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6a0dfae.simple-module-python.pages.dev |
| Branch Preview URL: | https://fix-db-review-audit.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with_loader_criteriaoptions, plus only the execute params that its own WHERE/criteria bind. The audited ids therefore equal the rows the UPDATE/DELETE changed, and a caller's param can't collide with the prefetch's ownLIMITbind.is_deletedTrue → False) now records arestoredentry. The audit log shows it with a pill, a filter option and en/de labels.updateddiff.docs/modules/audit_log.mdand the CHANGELOG are updated. The docs now note that restores and soft-deletes of versioned models carry aversiondiff.Verification
make lintpassed, along with these suites:make test-py: 7689 passedmake test-js: 892 passedmake doctor: cleanframework/db/tests/test_db_audit_regressions.pyandmodules/audit_log/tests-js/ChangesList.test.tsx.Closes #810
Closes #811
Test plan
https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq