Cancellation flow#26
Merged
Merged
Conversation
… loadingFinished paths - Make AnyTask.waitComplete throwing; use task.value instead of task.result so cancellation propagates - Call loadingFinished in each error branch of dispatch rather than after catch - Rethrow errors from dispatch so callers receive cancellation/error signals - Conform ActionLocker.Errors to NonPresentableError - Fix unlock to removeValue instead of setting false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(cancellation): propagate errors through waitComplete and fix loadingFinished paths
Make AnyTask.waitComplete throwing; use task.value instead of task.result so cancellation propagates
Call loadingFinished in each error branch of dispatch rather than after catch
Rethrow errors from dispatch so callers receive cancellation/error signals
Conform ActionLocker.Errors to NonPresentableError
Fix unlock to removeValue instead of setting false