PHP 8.6 | Tests: handle change in error message format - #217
Merged
Conversation
* As support for PHP < 7.1 has been dropped, we can use `PHP_VERSION_ID` instead of `PHP_VERSION` for the version comparisons. * Using a positive condition instead of a negative one improves the readability of the test code. * Ensure the tests have unique names.
This update the `require-missing*.phpt` tests by adding a new test file to handle the PHP 8.6+ format of the expected error messages. Ref: https://wiki.php.net/rfc/display_error_function_args
antecedent
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests/require-missing: clarify skip conditions
PHP_VERSION_IDinstead ofPHP_VERSIONfor the version comparisons.PHP 8.6 | Tests: handle change in error message format
This update the
require-missing*.phpttests by adding a new test file to handle the PHP 8.6+ format of the expected error messages.Ref: https://wiki.php.net/rfc/display_error_function_args