fix(app): skip legacy config reads for v2 - #40211
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #40209
Type of change
What does this PR do?
V2 servers do not expose the legacy config endpoints, but app bootstrap was still requesting them. This skips the global and directory config reads after the server is identified as V2, allowing directory bootstrap to finish normally. V1 config loading is unchanged.
How did you verify your code works?
bun test --conditions=solid --preload ./happydom.ts ./src/context/global-sync/bootstrap.test.tsbun typecheckbun run buildScreenshots / recordings
Not applicable; there are no UI changes.
Checklist