Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ type RemoteTarget = Extract<Target, { type: "remote" }>
type RequestPlan = Data.TaggedEnum<{
InvalidWorkspace: {}
MissingWorkspace: { readonly workspaceID: WorkspaceV2.ID }
MissingDirectory: {}
Local: { readonly directory: string; readonly workspaceID?: WorkspaceV2.ID }
Remote: {
readonly request: HttpServerRequest.HttpServerRequest
Expand Down Expand Up @@ -83,8 +84,8 @@ function selectedV2WorkspaceID(
return workspaceID.value
}

function defaultDirectory(request: HttpServerRequest.HttpServerRequest, url: URL): string {
return url.searchParams.get("directory") || request.headers["x-opencode-directory"] || process.cwd()
function defaultDirectory(request: HttpServerRequest.HttpServerRequest, url: URL): string | undefined {
return url.searchParams.get("directory") || request.headers["x-opencode-directory"] || undefined
}

function shouldStayOnControlPlane(request: HttpServerRequest.HttpServerRequest, url: URL): boolean {
Expand Down Expand Up @@ -178,8 +179,10 @@ function planRequest(
return yield* planWorkspaceRequest(request, url, workspace)
}

const directory = session?.directory || defaultDirectory(request, url)
if (directory === undefined) return RequestPlan.MissingDirectory()
return RequestPlan.Local({
directory: session?.directory || defaultDirectory(request, url),
directory,
workspaceID: envWorkspaceID ?? workspaceID,
})
})
Expand All @@ -203,6 +206,17 @@ function routeWorkspace<E>(
),
),
MissingWorkspace: ({ workspaceID }) => Effect.succeed(missingWorkspaceResponse(workspaceID)),
MissingDirectory: () =>
Effect.succeed(
HttpServerResponse.jsonUnsafe(
new InvalidRequestError({
message: "Missing directory: set ?directory= or x-opencode-directory",
kind: "Query",
field: "directory",
}),
{ status: 400 },
),
),
Remote: ({ request, workspace, target, url }) => proxyRemote(client, request, workspace, target, url),
Local: ({ directory, workspaceID }) =>
effect.pipe(Effect.provideService(WorkspaceRouteContext, WorkspaceRouteContext.of({ directory, workspaceID }))),
Expand Down
19 changes: 19 additions & 0 deletions packages/opencode/test/server/httpapi-session.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -792,6 +792,25 @@ describe("session HttpApi", () => {
{ git: true, config: { formatter: false, lsp: false, share: "disabled" } },
)

it.instance(
"rejects directory-less session creation with a v2 public request error",
() =>
Effect.gen(function* () {
const created = yield* request(SessionPaths.create, {
method: "POST",
headers: { "content-type": "application/json" },
})

expect(created.status).toBe(400)
expect(yield* responseJson(created)).toMatchObject({
_tag: "InvalidRequestError",
kind: "Query",
field: "directory",
})
}),
{ git: true, config: { formatter: false, lsp: false, share: "disabled" } },
)

it.instance(
"persists selected workspace id when creating a session",
() =>
Expand Down
13 changes: 11 additions & 2 deletions packages/server/src/handlers/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import { SessionsCursor } from "@opencode-ai/protocol/groups/session"
import {
ConflictError,
InvalidCursorError,
InvalidRequestError,
MessageNotFoundError,
ServiceUnavailableError,
SessionNotFoundError,
UnknownError,
} from "@opencode-ai/protocol/errors"
import { AbsolutePath } from "@opencode-ai/core/schema"

const DefaultSessionsLimit = 50
const DefaultSessionHistoryLimit = 50
Expand Down Expand Up @@ -67,12 +67,21 @@ export const SessionHandler = HttpApiBuilder.group(Api, "server.session", (handl
.handle(
"session.create",
Effect.fn(function* (ctx) {
if (ctx.payload.location === undefined) {
return yield* Effect.fail(
new InvalidRequestError({
message: "Missing location: create a session at an explicit location",
kind: "Payload",
field: "location",
}),
)
}
return {
data: yield* session.create({
id: ctx.payload.id,
agent: ctx.payload.agent,
model: ctx.payload.model,
location: ctx.payload.location ?? { directory: AbsolutePath.make(process.cwd()) },
location: ctx.payload.location,
}),
}
}),
Expand Down
24 changes: 18 additions & 6 deletions packages/server/src/location.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import { Location } from "@opencode-ai/core/location"
import { LocationServiceMap } from "@opencode-ai/core/location-services"
import { AbsolutePath } from "@opencode-ai/core/schema"
import { WorkspaceV2 } from "@opencode-ai/core/workspace"
import { InvalidRequestError } from "@opencode-ai/protocol/errors"
import { Effect, Layer } from "effect"
import { HttpServerRequest } from "effect/unstable/http"
import { HttpServerRequest, HttpServerResponse } from "effect/unstable/http"
import { HttpApiMiddleware } from "effect/unstable/httpapi"

export type LocationServices = Layer.Success<ReturnType<(typeof LocationServiceMap.Service)["get"]>>
Expand All @@ -26,12 +27,12 @@ export function response<A, E, R>(data: Effect.Effect<A, E, R>) {
})
}

function ref(request: HttpServerRequest.HttpServerRequest): Location.Ref {
function ref(request: HttpServerRequest.HttpServerRequest): Location.Ref | undefined {
const query = new URL(request.url, "http://localhost").searchParams
const workspaceID = query.get("location[workspace]") || request.headers["x-opencode-workspace"]
const directory =
query.get("location[directory]") ||
(request.headers["x-opencode-directory"] ? decode(request.headers["x-opencode-directory"]) : process.cwd())
const headerDirectory = request.headers["x-opencode-directory"]
const directory = query.get("location[directory]") || (headerDirectory ? decode(headerDirectory) : undefined)
if (directory === undefined) return undefined
return Location.Ref.make({
directory: AbsolutePath.make(directory),
workspaceID: workspaceID ? WorkspaceV2.ID.make(workspaceID) : undefined,
Expand All @@ -53,7 +54,18 @@ export const layer = Layer.effect(
return LocationMiddleware.of((effect) =>
Effect.gen(function* () {
const request = yield* HttpServerRequest.HttpServerRequest
return yield* effect.pipe(Effect.provide(locations.get(ref(request))))
const location = ref(request)
if (location === undefined) {
return HttpServerResponse.jsonUnsafe(
new InvalidRequestError({
message: "Missing directory: set x-opencode-directory or location[directory]",
kind: "Query",
field: "location[directory]",
}),
{ status: 400 },
)
}
return yield* effect.pipe(Effect.provide(locations.get(location)))
}),
)
}),
Expand Down
Loading